Fix #33531: Page view menu positioning [4.7.4] - #33867
Merged
mathesoncalum merged 1 commit intoJun 22, 2026
Merged
Conversation
4 tasks
mathesoncalum
force-pushed
the
33531-menuview_empty_space-474
branch
from
June 19, 2026 09:17
1bf2fd0 to
9be87a0
Compare
Eism
approved these changes
Jun 19, 2026
Contributor
|
Tested on MacOS Tahoe 26.2, Windows 11, Ubuntu 22.04.3. Approved |
This was referenced Jun 23, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #33531
Two problems:
newPopupPoswas being set toPopupPosition::Left(introduced in #31657). This is inaccurate since we're not actually placing the menu to the left - we're just shuffling it left by the overlap amount (it's still placed above).ThemovePoscall is incorrect/outdated - instead of shuffling left by the overlap amount we're actually shuffling it right bypadding() * 2(see the 4.6.5 screenshot attached to the original issue - the menu is offset).