[MusicXML] Fix unwanted text style setting#32455
Open
rettinghaus wants to merge 3 commits intomusescore:masterfrom
Open
[MusicXML] Fix unwanted text style setting#32455rettinghaus wants to merge 3 commits intomusescore:masterfrom
rettinghaus wants to merge 3 commits intomusescore:masterfrom
Conversation
Contributor
|
Yes, I think it would be a good idea to exclude roman numerals from having their font set by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #31953
The problem was, that Edwin was set as a default font for MusicXML imports and applied to (almost) all text styles.
Now, for MusicXML files without a specified
word-font, MuseScores default styles are not changed.Still, if a
word-fontis given in the imported file, all text styles are set to this font. We may want to exclude roman numerals completely from this.