20998: Added a midi mapping for 'Enter rest'; improved rest entry in 'Re-pitch existing notes' mode

[krasko78]

Resolves: #20998

Adds a midi mapping for the "Enter rest" ui action which is also tied to the "Enter rest" shortcut (normally 0 and Num 0).

I think I am seeing a couple of issues with the "Enter rest" action in general:

• In Rhythm only input mode, "Enter rest" acts as "Toggle rest". Is this expected? Does "Enter rest" make any sense in this mode at all?
• More importantly, in Re-pitch only mode "Enter rest" enters a rest but changes the duration to the currently selected duration instead of retaining the whatever duration the underlying note has (similar to "Input by note name" mode). I don't think this is correct. Personally I enter my scores in Rhythm only mode, then Re-pitch only mode. During the first phase, I'd enter a rest as a note being interested only in its duration, and then during the second phase I'd change the note to a rest but I'd not expect the duration to change.

Thoughts?

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[krasko78]

See also the discussion in the issue itself.

[avvvvve]

@krasko78 Just so I understand correctly, the only change to input modes is that in 'Re-pitch existing notes' mode, pressing 0 now replaces the current note with a rest that matches its duration rather than the duration selected in the note input bar.

Before, it did this:

nightly-repitch-rests.mov

Now, it does this:

pr-repitch-rests.mov

Definitely an improvement!

---

Looks good on my end but @DmitryArefiev would appreciate if you can give this a test

[avvvvve]

Update the title to describe the entry mode change.

Also re:

In Rhythm only input mode, "Enter rest" acts as "Toggle rest". Is this expected? Does "Enter rest" make any sense in this mode at all?

As discussed in other linked issues, this is expected.

[krasko78]

@avvvvve That's all correct. :)

[DmitryArefiev]

@krasko78 Hi! Can you rebase please?

[krasko78]

@DmitryArefiev Done. Thank you!

[DmitryArefiev]

Tested #20998 on Win10, Mac13.6, LinuxUbuntu24.04.2 LTS with NI M32 MIDI keyaboard - PASS

@krasko78 Thank you!