Fix system-text line visible when all staves hidden and code improvement #26343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, what would that one LOC fix have been? |
oktophonie
approved these changes
Feb 5, 2025
RomanPudashkin
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #25123
The fix in itself was one LOC, but as I looked into it I realized that this function was unnecessarily complex and expensive. Even though for the vast majority of items (which are not system-objects) the function exits at the first check, this is a function that gets called at every frame refresh for every item on screen, so it's still important to avoid stuff like
The name was also misleading, so I've changed it to
effectiveStaffIdx.