Skip to content

Conversation

@sammik
Copy link
Contributor

@sammik sammik commented Nov 28, 2022

Resolves easier ones of #14815

  • ledger lines spaces in customised line space staves
  • ledger line width in scaled staves
  • dotted rest dot position in scaled staves
  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@sammik sammik mentioned this pull request Nov 28, 2022
7 tasks
@sammik sammik changed the title Shadow couple fixes Shadow note couple fixes Nov 29, 2022
@RomanPudashkin RomanPudashkin merged commit d2ef994 into musescore:master Dec 20, 2022
@sammik sammik deleted the shadow-note-fixes branch December 20, 2022 11:46
@RMRattray
Copy link
Contributor

Can confirm that issues 4-7 still occur; as such, I'd like to work on them if I might.

@cbjeukendrup
Copy link
Member

@RMRattray feel free to! That would be appreciated. (I can't assign you yet though because you commented on this PR rather than on the issue 🙂)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants