Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestions for PR bbc#144 #1

Draft
wants to merge 22 commits into
base: update-timestamps-diff
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b9a0aad
Added timestamp update via diff tool
murezzda Apr 5, 2019
fa3b3a9
Added missing function
murezzda Apr 5, 2019
3833d94
Commited intermediate state
murezzda Apr 8, 2019
d434cae
Rewrote timestamp alignment and differ to be integrated in each other…
murezzda Apr 8, 2019
77cf2b9
Update Timestamps now works correctly.
murezzda Apr 10, 2019
db0b4a0
Fixed errors from rebase, removed debug code
murezzda Apr 12, 2019
e88f4ff
Moved UpdateTimestamp into its own folder.
murezzda Apr 15, 2019
fffe4ba
added updateTimestampsSSTAlign which updates the timestamps with the …
murezzda Apr 15, 2019
94b839c
some changes to show sudgestions for PR
pietrop Jun 23, 2019
3844ff1
updated branch
Jul 13, 2019
75d6114
added some of changes sudgested in PR
Jul 13, 2019
1174c8b
Adding speech to text adapter for Google cloud platform
sshniro Jul 18, 2019
f99d131
Update packages/stt-adapters/index.js
sshniro Jul 19, 2019
99048ed
Update packages/stt-adapters/index.js
sshniro Jul 19, 2019
778b4be
Update demo/select-stt-json-type.js
sshniro Jul 19, 2019
a8892ec
Rename GCP adapter folder to Google-stt
sshniro Jul 19, 2019
3a74e94
Renaming draft js sample response from google adapter to googleSttToD…
sshniro Jul 19, 2019
be93c08
Merge pull request #167 from sshniro/master
Jul 19, 2019
58db590
develop: Fix 159 performance problem (#171)
Jul 31, 2019
59505b0
develop: Update timestamps diff (#172)
Jul 31, 2019
82191f1
Update package.json
Jul 31, 2019
363c131
Merge branch 'develop' into murezzda-update-timestamps-diff
Jul 31, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion demo/app.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import React from 'react';

// https://github.com/maicki/why-did-you-update
// NOTE: This slows down performance, even during development
// if (process.env.NODE_ENV !== 'production') {
// const { whyDidYouUpdate } = require('why-did-you-update');
// whyDidYouUpdate(React, { exclude: [ /^HotKeysWrapper/ ] } );
// }
import TranscriptEditor from '../packages/components/transcript-editor';
import SttTypeSelect from './select-stt-json-type';
import ExportFormatSelect from './select-export-format';
Expand Down
1 change: 0 additions & 1 deletion demo/index.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ body {
@media (max-width: 767px) {
body {
padding: 0;
text-align: center;
}

.demoNavItem {
Expand Down
27 changes: 17 additions & 10 deletions demo/select-export-format.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,23 @@
import React from 'react';
import PropTypes from 'prop-types';

const ExportFormatSelect = props => {
return <select className={ props.className } name={ props.name } value={ props.value } onChange={ props.handleChange }>
<option value="draftjs">Draft Js</option>
<option value="txt">Text file</option>
<option value="txtspeakertimecodes">Text file - with Speakers and Timecodes</option>
<option value="html" disabled>HTML</option>
<option value="word" disabled>MS Word</option>
<option value="digitalpaperedit">Digital Paper Edit</option>
</select>;
};
// using PureComponent to minimise number of unnecessary re-renders
class ExportFormatSelect extends React.PureComponent {

render() {
const { props } = this;

return (<select className={ props.className } name={ props.name } value={ props.value } onChange={ props.handleChange }>
<option value="draftjs">Draft Js</option>
<option value="txt">Text file</option>
<option value="txtspeakertimecodes">Text file - with Speakers and Timecodes</option>
<option value="html" disabled>HTML</option>
<option value="word" disabled>MS Word</option>
<option value="digitalpaperedit">Digital Paper Edit</option>
</select>
);
}
}

ExportFormatSelect.propTypes = {
className: PropTypes.string,
Expand Down
1 change: 1 addition & 0 deletions demo/select-stt-json-type.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const SttTypeSelect = props => {
<option value="vtt-youtube" disabled>Youtube VTT</option>
<option value="amazontranscribe">Amazon Transcribe</option>
<option value="digitalpaperedit">Digital Paper Edit</option>
<option value="google-stt">Google STT</option>
</select>;
};

Expand Down
330 changes: 330 additions & 0 deletions docs/notes/2019-05-16-prevent-unnecessary-re-renders-in-react.md

Large diffs are not rendered by default.

Loading