suggestions for PR bbc#144

[pietrop]

Is your Pull Request request related to another issue in this repository ?

bbc#144

Describe what the PR does

some changes to show suggestions for PR bbc#144 around edge case of trying to preserve block level time-codes and speaker informations when user paste accurate text into the editor.

State whether the PR is ready for review or whether it needs extra work

Ready for review

Additional context

Just to demonstrate, show, and discuss ideas.

[pietrop]

Handling edge case: pasting accurate text in editor

This PR shows a possible way for handling edge case when pasting text for retaining paragraph timecode and speaker name

• handling timecode at paragraph level when corrected text is pasted into the editor
• handling speaker names at paragraph level by using default UKN speaker label, which is good if replacing everything, not so good if replacing a line inside a paragraph by pasting in the correct text (as we might want to keep the speaker name in that case).

speaker name


If you export draftJs json from the demo app, you can see that in the paragraph block there is a data.speaker attribute.



    {
      "key": "129ia",
      "text": "he'd ordered and I was really excited about it because I've always loved about this one has really caught technical features. It had more orders and touch sensors. It had an infra red camera and one of the things that had was a tilt sensor so it. Knew what direction. It was facing. If and when you held it upside down.",
      "type": "paragraph",
      "depth": 0,
      "inlineStyleRanges": [],
      "entityRanges": [
        {
          "offset": 0,
          "length": 4,
          "key": 29
        },
…..
      ],
      "data": {
        "speaker": "F_S12",
        "words": [
          {
            "start": 24.65,
            "confidence": 0.59,
            "end": 24.84,
            "word": "he'd",
            "punct": "he'd",
            "index": 29,
            "speaker": "F_S12"
          },

in createEntity (or a bit cleaner, in another function as a second pass) you might need to add speaker names so that you can access it in createContentFromEntityList

Not sure if start is under block.data.start in createContentFromEntityList

TL;DR: See the diffs in this PR for some suggestions around possible ways to handle edge case when user pastes text for retaining paragraph timecode and speaker name.

[pietrop]

Another possible solution is to catch the pasted text further upstream and to use handlePastedText also mentioned in this article about race condition as well as this comment.

The hunch being that when you paste some text into the editor, it is missing the entities so draftjs does not identify it as words, and therefore speaker and time info are missing.