✨ New Zoned Neutral Atom Compiler by ystade · Pull Request #624 · munich-quantum-toolkit/qmap

ystade · 2025-04-05T10:24:30Z

Description

This rather big (sorry for that) PR adds a new compiler for zoned neutral atom architectures. The key benefit is its modular structure. This should ease the further development of the compiler as only components of the compiler must be touched.

This implementation in C++ is based on its previous implementation in Python from here and its corresponding article here.

Checklist:

The pull request only contains commits that are related to it.
I have added appropriate tests and documentation.
I have made sure that all CI jobs on GitHub pass.
The pull request introduces no new warnings and follows the project's style guidelines.

# Conflicts: # include/na/Architecture.hpp # include/na/nasp/CodeGenerator.hpp # include/na/nasp/SolverFactory.hpp # src/na/Architecture.cpp # src/na/nasp/CodeGenerator.cpp # src/na/nasp/SolverFactory.cpp # test/na/nasp/test_codegenerator.cpp # test/na/nasp/test_solver.cpp # test/na/nasp/test_solverfactory.cpp

# Conflicts: # include/na/nalac/NAMapper.hpp # include/na/nalac/datastructures/Architecture.hpp # include/na/nasp/SolverFactory.hpp # src/na/nalac/NAMapper.cpp # src/na/nalac/datastructures/Architecture.cpp # src/na/nasp/CodeGenerator.cpp # src/na/nasp/SolverFactory.cpp # test/na/nasp/test_codegenerator.cpp # test/na/nasp/test_solver.cpp # test/na/nasp/test_solverfactory.cpp

This reverts commit 5b587d5.

ystade · 2025-05-23T14:12:51Z

@burgholzer When I am not mistaken, there is only one open comment waiting for your response. Besides that, I resolved all other comments by making appropriate changes. Furthermore, I added multiple entries to the CHANGELOG and also a short note to the UPGRADING notes.

burgholzer

Thanks for all the work on this.
I believe this is ready for a first release.
The two typos should be easily fixed by adopting the suggestions.
Feel free to ignore the third comment. It's just something that caught my eye.

You know the drill for preparing a release already from the workflows release. Same holds here 🙂
Maybe check the release draft to make sure that there are no unlabeled PRs.

Co-authored-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>

ystade · 2025-05-26T07:18:22Z

You know the drill for preparing a release already from the workflows release. Same holds here 🙂
Maybe check the release draft to make sure that there are no unlabeled PRs.

Should this be a patch release or minor release?

burgholzer · 2025-05-26T07:59:39Z

You know the drill for preparing a release already from the workflows release. Same holds here 🙂

Maybe check the release draft to make sure that there are no unlabeled PRs.

Should this be a patch release or minor release?

This PR here should be tagged with the minor label and the release should be a minor one. I believe features as big as this deserve their own "big" release.

## Description This PR prepares the CHANGELOG.md and the UPGRADING.md for the upcoming release of v3.1.0 that includes the new NA compiler. Additionally, it fixes a broken link that was overlooked in #624. ## Checklist:  - [x] The pull request only contains commits that are focused and relevant to this change. - [ ] I have added appropriate tests that cover the new/changed functionality. - [ ] I have updated the documentation to reflect these changes. - [x] I have added entries to the changelog for any noteworthy additions, changes, fixes or removals. - [x] I have added migration instructions to the upgrade guide (if needed). - [x] The changes follow the project's style guidelines and introduce no new warnings. - [ ] The changes are fully tested and pass the CI checks. - [x] I have reviewed my own code changes.

## Description This PR aligns the implementation of Python bindings with the implementation introduced in [qmap#624](munich-quantum-toolkit/qmap#624). To this end, a helper function `add_mqt_core_binding` is introduced. ## Checklist: - [x] The pull request only contains commits that are focused and relevant to this change. - [x] ~~I have added appropriate tests that cover the new/changed functionality.~~ - [x] ~~I have updated the documentation to reflect these changes.~~ - [x] I have added entries to the changelog for any noteworthy additions, changes, fixes or removals. - [x] I have added migration instructions to the upgrade guide (if needed). - [x] The changes follow the project's style guidelines and introduce no new warnings. - [x] The changes are fully tested and pass the CI checks. - [x] I have reviewed my own code changes. --------- Signed-off-by: Daniel Haag <121057143+denialhaag@users.noreply.github.com> Co-authored-by: Yannick Stade <100073938+ystade@users.noreply.github.com> Co-authored-by: Lukas Burgholzer <burgholzer@me.com>

## Description This PR aligns the implementation of Python bindings with the implementation introduced in munich-quantum-toolkit/qmap#624. ## Checklist: - [x] The pull request only contains commits that are focused and relevant to this change. - [x] ~~I have added appropriate tests that cover the new/changed functionality.~~ - [x] I have updated the documentation to reflect these changes. - [x] I have added entries to the changelog for any noteworthy additions, changes, fixes or removals. - [x] I have added migration instructions to the upgrade guide (if needed). - [x] The changes follow the project's style guidelines and introduce no new warnings. - [x] The changes are fully tested and pass the CI checks. - [x] I have reviewed my own code changes. --------- Signed-off-by: Daniel Haag <121057143+denialhaag@users.noreply.github.com> Signed-off-by: Lukas Burgholzer <burgholzer@me.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lukas Burgholzer <burgholzer@me.com>

## Description This PR aligns the implementation of Python bindings with the implementation introduced in munich-quantum-toolkit/qmap#624. ## Checklist: - [x] The pull request only contains commits that are focused and relevant to this change. - [x] ~~I have added appropriate tests that cover the new/changed functionality.~~ - [x] ~~I have updated the documentation to reflect these changes.~~ - [x] I have added entries to the changelog for any noteworthy additions, changes, fixes or removals. - [x] I have added migration instructions to the upgrade guide (if needed). - [x] The changes follow the project's style guidelines and introduce no new warnings. - [x] The changes are fully tested and pass the CI checks. - [x] I have reviewed my own code changes. --------- Signed-off-by: Lukas Burgholzer <burgholzer@me.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lukas Burgholzer <burgholzer@me.com>

## Description This PR further streamlines the implementation of Python bindings. It is a continuation of #624. ## Checklist: - [x] The pull request only contains commits that are focused and relevant to this change. - [x] ~~I have added appropriate tests that cover the new/changed functionality.~~ - [x] I have updated the documentation to reflect these changes. - [x] I have added entries to the changelog for any noteworthy additions, changes, fixes or removals. - [x] I have added migration instructions to the upgrade guide (if needed). - [x] The changes follow the project's style guidelines and introduce no new warnings. - [x] The changes are fully tested and pass the CI checks. - [x] I have reviewed my own code changes. --------- Signed-off-by: Daniel Haag <121057143+denialhaag@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lukas Burgholzer <burgholzer@me.com>

ystade added 30 commits March 3, 2025 13:07

🎨 Restructure architecture

ac684de

🔥 Delete source files that cannot be used due to templates

14569d1

🎨 Fix architecture

8763722

🐛 Fix bugs in architecture, replace whole preprocessing

b50d2fc

🎨 Add error handling to architecture's load function

00fd128

🐛 Fix load function

2462205

✅ Test architecture

95fc7b2

🐛 Fix bug in max Matching

75a7fab

🐛 Fix minWeightFullBipartiteMatching

2c6a14d

✅ Add another test

2eda282

🎨 Get it to compile

b538c0c

✅ Succeed test to load settings

d2e1bf1

🎨 Add constexpr string

5cc6302

🎨 Get it compile

cde6ebf

🎨 Enforce CamelCases

fbacdea

🎨 Get everything to not throw an exception

41b9a9f

🐛 Fix several bugs

ae489b8

🐛 Fix bug in minWeightFullMatching

6ead743

🐛 Fix another bug in minWeightFullMatching

3967aec

🎨 Isolate nalac

5b61605

🐛 Fix bug with 1Q Gates

7f36267

🔥 Remove azac

3d16be3

🎨 Remove yaml in solver

115d8ea

🐛 Adopt new NA computation in entire project

7808a94

🎨 Add missing link target

72e7ee9

🐛 Use mqt-core branch

e19f8a1

🎨 Fix python bindings

999b88b

Revert "🔥 Remove azac"

927ce84

This reverts commit 5b587d5.

burgholzer approved these changes May 24, 2025

View reviewed changes

Comment thread UPGRADING.md Outdated

Comment thread python/mqt/qmap/na/__init__.py Outdated

Comment thread test/python/test.py

ystade and others added 3 commits May 24, 2025 09:24

Update python/mqt/qmap/na/__init__.py

95ae77b

Co-authored-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>

Update UPGRADING.md

6944bd9

Co-authored-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>

⏪️ Revert reordering in python files

7389a7d

ystade and others added 2 commits May 26, 2025 09:19

Merge branch 'main' into wip-azac

d4c7f15

🎨 pre-commit fixes

9e62caa

ystade and others added 3 commits May 26, 2025 11:01

🐛 Fix ruff config

0d4f5a0

📝 Add dcos to compiler

f29d886

🎨 pre-commit fixes

f4c9550

ystade enabled auto-merge (squash) May 26, 2025 12:14

ystade merged commit 1dad2ff into main May 26, 2025

ystade deleted the wip-azac branch May 26, 2025 12:17

github-project-automation Bot moved this from In Progress to Done in MQT Compilation May 26, 2025

github-project-automation Bot moved this from In Progress to Done in MQT May 26, 2025

ystade mentioned this pull request May 26, 2025

📝 Prepare Release v3.1.0 #658

Merged

8 tasks

This was referenced Jun 2, 2025

🎨🐍 Streamline Python bindings munich-quantum-toolkit/core#982

Merged

♻️ Update outdated filter after restructuring MQT repos munich-quantum-toolkit/workflows#119

Merged

coderabbitai Bot mentioned this pull request Oct 15, 2025

🔖 Prepare release of v3.4.0 #805

Merged

8 tasks

Navigation Menu

Uh oh!

Uh oh!

✨ New Zoned Neutral Atom Compiler - #624

✨ New Zoned Neutral Atom Compiler#624
ystade merged 270 commits into
mainfrom
wip-azac

ystade commented Apr 5, 2025 •

edited

Loading

Uh oh!

ystade commented May 23, 2025

Uh oh!

burgholzer left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ystade commented May 26, 2025

Uh oh!

burgholzer commented May 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

ystade commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist:

Uh oh!

ystade commented May 23, 2025

Uh oh!

burgholzer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ystade commented May 26, 2025

Uh oh!

burgholzer commented May 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ystade commented Apr 5, 2025 •

edited

Loading