Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins: use the short form of peekProc #2611

Merged
merged 1 commit into from
Oct 31, 2016
Merged

plugins: use the short form of peekProc #2611

merged 1 commit into from
Oct 31, 2016

Conversation

davidebeatrici
Copy link
Member

@davidebeatrici davidebeatrici commented Oct 31, 2016 •
edited
Loading

The short form of peekProc automatically uses the correct size for the target.

@davidebeatrici
plugins: use the short form of peekProc
921ee19 
The short form of peekProc automatically uses the correct size for the target.
@mkrautz
Copy link
Contributor

mkrautz commented Oct 31, 2016

LGTM

@mkrautz mkrautz merged commit e9c558f into mumble-voip:master Oct 31, 2016
@davidebeatrici davidebeatrici deleted the plugins-short-peekproc branch October 31, 2016 23:12
davidebeatrici added a commit to davidebeatrici/mumble that referenced this pull request Nov 3, 2016
@davidebeatrici
plugins: fix compile error on Linux
685b5d6 
This fixes mumble-voip#2615, introduced by mumble-voip#2611.
@davidebeatrici davidebeatrici mentioned this pull request Nov 3, 2016
Merged
Kissaki added a commit that referenced this pull request Nov 17, 2016
@Kissaki
Fix 2643: Revert "Merge PR #2611: plugins: use the short form of peek…
e2ad9c0 
…Proc"

This reverts commit e9c558f, reversing
changes made to ca2fd07.

This is a quick-fix for crashing PA plugins. The intended change is
still useful and planned to land later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client positional audio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidebeatrici @mkrautz