Add additional setWeaponProperty customizations#4691
Open
DeValdi wants to merge 1 commit intomultitheftauto:masterfrom
Open
Add additional setWeaponProperty customizations#4691DeValdi wants to merge 1 commit intomultitheftauto:masterfrom
DeValdi wants to merge 1 commit intomultitheftauto:masterfrom
Conversation
This change unlocks the "anim_group" weapon property's setter and gives
access to the natively supported fourth skill level ("special").
The two changes complement each other, since developers are more likely
to use the first feature (i.e. an additional weapon animation) if it
means not overriding an already in-use skill level.
To specify the "special" skill level as the target of setWeaponProperty
calls, pass "special" instead of "poor", "std", or "pro".
The "anim_group" property expects as argument the animation group ID in
the form of an integer. The wiki page on setWeaponProperty should
be updated with additional information, since the ID's are only visible
in code.
To make a ped use the "special" skill level, assign a stat value of
5000 to the weapon stat. This reflects the same value used by GTA:SA
for the cops' pistol animation (the only place where this skill level
is used by the base game).
The Lua function setPedStat has been updated to differentiate between
weapon and non-weapon stats, notably for value checking (maximum is
either 5000 or 1000, respectively).
The weapon property sync structure was changed to include ALL weapon
properties, not just the one's that can be set via setWeaponProperty.
This is due to the fact that GTA:SA seems to clear the "special" skill
level entries when joining the server, which also includes indices,
slot numbers, etc. There was no problem before (with just the "poor",
"std" and "pro" levels) since these entries do not get cleared and the
server only had to override the relevant properties when joining.
By default, the "special" skill levels for all weapons but the pistol
inherit their properties from their "pro" counterparts. The pistol uses
the "cop_colt" configuration provided by the game's "weapon.dat" file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Test plan
I did some very basic testing on a Windows device by giving my in-game character weapons and switching between the skill levels. It seems to work for me, but that is of course not to say that it does for everyone. I appreciate any feedback or concerns on this new mechanism.
Checklist