[charts-pro] Avoid relative reference to @mui/x-charts package
#14335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
bug 🐛
|
Deploy preview: https://deploy-preview-14335--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #14335 will not alter performanceComparing Summary
|
LukasTy
commented
Aug 26, 2024
| @@ -11,8 +11,10 @@ | |||
| "packages/x-date-pickers", | |||
| "packages/x-date-pickers-pro", | |||
| "packages/x-charts", | |||
| "packages/x-charts-pro", | |||
There was a problem hiding this comment.
I wanted to check the issue with a CodeSandbox published package and noticed that we are not publishing new pro packages in CI.
Do you think there is a reason for it, or did we just forget to add them to the list? 🤔
There was a problem hiding this comment.
I think we just forgot it
JCQuintas
reviewed
Aug 26, 2024
| } from '@mui/x-charts/internals'; | ||
| import { ChartsAxisProps, ScaleName, AxisConfig } from '@mui/x-charts'; | ||
| import { ZoomData } from '../ZoomProvider'; | ||
| import { getScale } from '../../../../x-charts/src/internals/getScale'; |
There was a problem hiding this comment.
Didn't eslint pick this up? 😮
There was a problem hiding this comment.
Somehow it didn't. 🤔
Could be because of the issues in the ESLint config that are pending resolution: #13401
JCQuintas
approved these changes
Aug 26, 2024
This was referenced Sep 20, 2024
This was referenced Sep 27, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14314.