Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts-pro] Dependency local workspace reference causes runtime errors on createAxisFilterMapper #14314

Closed
PatoGuereque opened this issue Aug 23, 2024 · 2 comments · Fixed by #14335
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user support: pro standard Support request from a Pro standard plan user. https://mui.com/legal/technical-support-sla/

Comments

@PatoGuereque
Copy link

PatoGuereque commented Aug 23, 2024

Hello,

I noticed the following issue while trying to use the new zoom feature on charts-pro.

The following import is using a relative path to x-charts, rather than using @mui/x-charts.

import { getScale } from '../../../../x-charts/src/internals/getScale';

https://github.com/mui/mui-x/blob/b321b4076a977148d8f23cfd57e49906df4534b8/packages/x-charts-pro/src/context/CartesianProviderPro/createAxisFilterMapper.ts#L12C27-L12C39

This causes errors when resolving dependencies

Error:

✘ [ERROR] Could not resolve "../../../../x-charts/src/internals/getScale"

    node_modules/@mui/x-charts-pro/context/CartesianProviderPro/createAxisFilterMapper.js:2:25:
      2 │ import { getScale } from '../../../../x-charts/src/internals/getScale';
        ╵                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Link to live example: CodeSandbox

I believe I'd need to sign a CLA if I were to open a PR, even though it's a 2-3 line patch. Am I correct?

Regards,
Pato

Search keywords: x-charts-pro
Order ID: 96664

@PatoGuereque PatoGuereque added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 23, 2024
@github-actions github-actions bot added component: charts This is the name of the generic UI component, not the React module! support: pro standard Support request from a Pro standard plan user. https://mui.com/legal/technical-support-sla/ labels Aug 23, 2024
@LukasTy
Copy link
Member

LukasTy commented Aug 26, 2024

Hello @PatoGuereque.
Thank you for being so quick to adopt new features! 🙏
We are sorry that this issue got passed our checks. 🙈

I believe I'd need to sign a CLA if I were to open a PR, even though it's a 2-3 line patch. Am I correct?

Yes, that is the case, I've opened a PR to avoid the extra hassle for such a small fix. 👍

@LukasTy LukasTy added plan: Pro Impact at least one Pro user and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 26, 2024
Copy link

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@PatoGuereque: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user support: pro standard Support request from a Pro standard plan user. https://mui.com/legal/technical-support-sla/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants