Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moduleResolution:node for icons #45444

Merged
merged 4 commits into from
Mar 3, 2025
Merged

Fix moduleResolution:node for icons #45444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8244550
Fix moduleResolution:node for icons
Janpot Feb 28, 2025
a65e3de
Merge remote-tracking branch 'upstream/master' into res-node-icons
Janpot Mar 1, 2025
bd58960
test
Janpot Mar 1, 2025
3fd4d69
Add more tests
Janpot Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,9 @@ jobs:
- run:
name: Build packages for fixtures
command: pnpm release:build
- run:
name: Analyze exported typescript
command: pnpm test:attw
- run:
name: Run visual regression tests using Pigment CSS
command: xvfb-run pnpm test:regressions-pigment-css
Expand Down
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"start": "pnpm install && pnpm docs:dev",
"test": "node scripts/test.mjs",
"tc": "nx run nx_test_tc",
"test:attw": "pnpm run --parallel -r attw",
"test:extended": "pnpm eslint && pnpm typescript && pnpm test:coverage",
"test:coverage": "nx run nx_test_coverage",
"test:coverage:ci": "nx run nx_test_coverage_ci",
Expand Down Expand Up @@ -107,6 +108,7 @@
"google-auth-library": "^9.15.1"
},
"devDependencies": {
"@arethetypeswrong/cli": "^0.17.4",
"@argos-ci/core": "^3.1.0",
"@babel/cli": "^7.26.4",
"@babel/core": "^7.26.9",
Expand Down
13 changes: 12 additions & 1 deletion packages/mui-icons-material/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@
"src:icons": "cross-env UV_THREADPOOL_SIZE=64 node ./builder.mjs --output-dir src --svg-dir material-icons --renameFilter ./renameFilters/material-design-icons.mjs && pnpm build:lib:clean",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-icons-material/**/*.test.?(c|m)[jt]s?(x)'",
"test:built-typings": "tsc -p test/generated-types/tsconfig.json",
"typescript": "tsc -p tsconfig.json"
"typescript": "tsc -p tsconfig.json",
"attw": "attw --pack ./build --exclude-entrypoints esm --include-entrypoints Close"
},
"dependencies": {
"@babel/runtime": "^7.26.9"
Expand Down Expand Up @@ -85,6 +86,16 @@
"engines": {
"node": ">=14.0.0"
},
"typesVersions": {
"*": {
"index": [
"./index.d.ts"
],
"*": [
"./icon.d.ts"
]
}
},
"exports": {
".": {
"import": {
Expand Down
3 changes: 2 additions & 1 deletion packages/mui-material-nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
"prebuild": "rimraf build tsconfig.build.tsbuildinfo",
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-material-nextjs/**/*.test.?(c|m)[jt]s?(x)'",
"typescript": "tsc -p tsconfig.json"
"typescript": "tsc -p tsconfig.json",
"attw": "attw --pack ./build --exclude-entrypoints . esm modern --include-entrypoints v15-pagesRouter v15-appRouter"
},
"dependencies": {
"@babel/runtime": "^7.26.9"
Expand Down
3 changes: 2 additions & 1 deletion packages/mui-material/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-material/**/*.test.?(c|m)[jt]s?(x)'",
"typescript": "tsc -p tsconfig.json",
"typescript:module-augmentation": "node scripts/testModuleAugmentation.js"
"typescript:module-augmentation": "node scripts/testModuleAugmentation.js",
"attw": "attw --pack ./build --exclude-entrypoints esm modern --include-entrypoints Button styles"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the attw check for all packages?

Why exclude esm and modern?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few key packages that most people would use, and the icons that have a more exotic setup. didn't want to add too much to CI for packages that most people won't import and that won't regress on their own anyway as it all uses the same automation. We can remove the exclusions after arethetypeswrong/arethetypeswrong.github.io#242 is fixed.

},
"dependencies": {
"@babel/runtime": "^7.26.9",
Expand Down
Loading