Skip to content

[docs-infra] Fix API search link regression #43662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024
Merged

[docs-infra] Fix API search link regression #43662

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bfff9e
[docs-infra] Fix API search link regression
oliviertassinari Sep 8, 2024
30118c2
jan's review
oliviertassinari Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions docs/src/modules/components/ApiPage/list/ExpandableApiItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,19 @@ const Root = styled('div')<{ ownerState: { type?: DescriptionType } }>(
({ theme }) => ({
position: 'relative',
marginBottom: 12,
scrollMarginTop: 'calc(var(--MuiDocs-header-height) + 32px)',
'& .MuiApi-item-header': {
minHeight: 26,
display: 'flex',
alignItems: 'center',
marginLeft: -38,
marginBottom: 8,
marginLeft: -38,
lineHeight: 1.5,
},
'& .MuiApi-item-header-link': {
minHeight: 26,
display: 'flex',
alignItems: 'center',
scrollMarginTop: 'calc(var(--MuiDocs-header-height) + 32px)',
},
'& .MuiApi-item-link-visual': {
display: 'none',
flexShrink: 0,
Expand Down Expand Up @@ -179,30 +183,28 @@ export default function ExpandableApiItem(props: ExpandableApiItemProps) {
setIsExtended(displayOption === 'expanded');
}, [displayOption]);

const anchorLabelId = React.useId();

return (
<Root
ownerState={{ type }}
{...other}
id={id}
className={clsx(
`MuiApi-item-root ${isExtendable ? 'MuiApi-item-header-extendable' : ''}`,
`MuiApi-item-root${isExtendable ? ' MuiApi-item-header-extendable' : ''}`,
className,
)}
>
<div className="MuiApi-item-header">
<a className="MuiApi-item-link-visual" href={`#${id}`} aria-labelledby={anchorLabelId}>
<svg>
<use xlinkHref="#anchor-link-icon" />
</svg>
</a>
<span
id={anchorLabelId}
className="MuiApi-item-title algolia-lvl3" // This className is used by Algolia
>
{title}
</span>
<div className="MuiApi-item-header-link" id={id}>
<a className="MuiApi-item-link-visual" href={`#${id}`} aria-labelledby={id}>
<svg>
<use xlinkHref="#anchor-link-icon" />
</svg>
</a>
<span
className="MuiApi-item-title algolia-lvl3" // This className is used by Algolia
>
{title}
</span>
</div>
{note && <span className="MuiApi-item-note">{note}</span>}
{isExtendable && (
<IconButton
Expand Down