Skip to content

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 8, 2024

The change in #43292 breaks the search experience on the API pages that have the "View: Expanded" default layout, for example https://mui.com/x/api/data-grid/data-grid-pro/. Algolia returns URLs with the React useId, e.g. https://mui.com/x/api/data-grid/data-grid/#:R86ml5l6kud6:. I believe this will fix it.

Preview: https://deploy-preview-43662--material-ui.netlify.app/material-ui/api/button/#button-prop-color

@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. type: regression A bug, but worse, it used to behave as expected. scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). labels Sep 8, 2024
@mui-bot
Copy link

mui-bot commented Sep 8, 2024

Netlify deploy preview

https://deploy-preview-43662--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 30118c2

@zannager zannager requested a review from Janpot September 9, 2024 14:22
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the accessibility tree it seems to have a drastic effect on the label.
Screenshot 2024-09-09 at 18 01 06
vs.
Screenshot 2024-09-09 at 18 01 16

Then again, the whole branch seems to be ignored anyway, so why were we doing this in the first place 😄

in any case, neither of those labels describe the control very well

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 11, 2024

People start to open issues with the wrong hashes 😄, e.g. mui/mui-x#14585

SCR-20240911-sbov

@oliviertassinari oliviertassinari force-pushed the docs-infra-fix-api-search branch from a0388c0 to 30118c2 Compare September 11, 2024 19:08
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 11, 2024

Looking at the accessibility tree it seems to have a drastic effect on the label.

Yeah, ok, fixed:

Before:

SCR-20240911-sifr

After:

SCR-20240911-sicb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants