[CardContent] Use theme.spacing() instead of hardcoded values
#32471
Conversation
|
Bundle size will be reported once CircleCI build #465837 finishes. |
MahmoudMans
changed the title
| maxWidth: 'calc(150% - 24px)', | ||
| transform: 'translate(12px, -9px) scale(0.70)', |
There was a problem hiding this comment.
Why this change? Let's not change this.
There was a problem hiding this comment.
@ZeeshanTamboli sorry this changes were related to another pull request
| import createTheme from '../styles/createTheme'; | ||
|
|
||
| const theme = createTheme(); |
There was a problem hiding this comment.
This is not needed. You can access the theme in styled() API
There was a problem hiding this comment.
What do you mean we can access it through the api ? can you give me an example please
There was a problem hiding this comment.
There was a problem hiding this comment.
also i opened this pull request because of this issue #32155
ZeeshanTamboli
changed the title
theme.spacing() instead of hardcoded values
ZeeshanTamboli
added
the
component: card
There was a problem hiding this comment.
Also I think this would be a breaking change in case some apps have their own theme customization with their own spacing values as mentioned in #32155 (comment)
ZeeshanTamboli
added
breaking change
on hold
| @@ -22,9 +22,9 @@ const CardContentRoot = styled('div', { | |||
| overridesResolver: (props, styles) => styles.root, | |||
| })(() => { | |||
| return { | |||
| padding: 16, | |||
| padding: styled.theme.spacing(2), | |||
There was a problem hiding this comment.
TypeError: Cannot read property 'spacing' of undefined
There was a problem hiding this comment.
It should be
})(({ theme }) => {
return {
padding: theme.spacing(2),
oliviertassinari
requested review from
siriwatknp,
hbjORbj,
michaldudak and
mnajdova
as code owners
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
oliviertassinari
modified the milestones:
Material UI: v7 (draft),
Material UI v8 (draft)
Closes #32155