URO-208: orcidlink main view #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed to extend KBaseBaseQueryError directly for TS
tried to keep the changes minimal
incomplete - still needs support for manager, developer, help text but this set of changes minimized
dauglyon
reviewed
May 13, 2024
dauglyon
reviewed
May 15, 2024
had followed the documentation which uses mui icons (and the docs have warnings and workarounds for fa icons,which may not be relevant here), but the fa icon does indeed work. Also overrides the default orientation and rotation, which matches the other usage in the codebase which itself matches the kbase-ui usage which matches the Narrative which uses an augmented bootstrap 3 "accordion". Notable, though that BS5 Accordions work the same as MUI (BS 3 and 4 do not use icon at all.) Also added the recommended aria- attributes.
this was really a note-to-self; it is also easily discoverable via VSC go-to-definition which is also more accurate vis-a-vis the version being used
rely upon adjustments to card content itself - e.g. remove margin and padding from top and bottom. But that adjustment depends on what is embedded in the content area, so leave to individual usages.
dauglyon
reviewed
May 17, 2024
dauglyon
reviewed
May 17, 2024
Okay, now I see them. There were collapsed down together and not displayed. |
it is currently the same as the jsonRpcService function
dauglyon
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populates the initial view for orcidlink based on whether the user is linked or not.
This set of changes adds improved orcidlink service api support, displays orcid link and orcid profile summary information in the initial view, for linked users, and a call to action for unlinked users.
This set of changes is about 600 LOC without tests, 1200 with tests. It could be pared down further, but this minimizes the changes without losing core functionality.
This view is incomplete, as the full set of changes to implement this view would be about 1200 LOC. I trimmed out a lot of content, such as help, some stub handling of button events, support for developer and manager detection and ui support. These changes have been made and are ready to layer on top of these changes once they are merged in.
One dependency was added - material icons. They seem to be required for integration into some MUI components, such as the Accordion.