[test] Consolidate on a single API / split infinitive #24884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
oliviertassinari
changed the title
oliviertassinari
added a commit
to mui/base-ui
that referenced
this pull request
Sep 8, 2025
Same as mui/material-ui#24884. We will need an eslint rule / make the API not work at one point.
oliviertassinari
added a commit
that referenced
this pull request
Sep 8, 2025
Same as #24884. We will need an eslint rule / make the API not work at one point.
oliviertassinari
pushed a commit
to mui/mui-x
that referenced
this pull request
Sep 8, 2025
Same as mui/material-ui#24884. We will need an eslint rule / make the API not work at one point.
atomiks
pushed a commit
to atomiks/base-ui
that referenced
this pull request
Sep 10, 2025
Same as mui/material-ui#24884. We will need an eslint rule / make the API not work at one point.
JCQuintas
pushed a commit
to JCQuintas/mui-x
that referenced
this pull request
Sep 15, 2025
Same as mui/material-ui#24884. We will need an eslint rule / make the API not work at one point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up on #24782 (comment)
Searching more on the difference, it seems that the two forms have no difference in meaning, so we might as well consolidate on the most popular as well as not splitting the infinitive.