[Slider] Fix override of event.target when preparing change events #24782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
scope: slider
eps1lon
requested changes
Feb 5, 2021
Member
eps1lon
left a comment
eps1lon
left a comment
There was a problem hiding this comment.
Thanks for the work!
Would you be so kind and add a test for this behavior. Otherwise we'll likely remove this code in the future since it's quite exotic.
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
slider-touch-event
branch
from
ed19b17 to
0dddb00
Compare
oliviertassinari
approved these changes
Feb 7, 2021
Member
oliviertassinari
left a comment
oliviertassinari
left a comment
There was a problem hiding this comment.
I have refined the solution, polished it a bit, and added a test case. It turns out that it only happens with the touch event, e.g. not the mouse down. I have added the target as the third property in case a developer has a specific use case that requires it, and done some other minor improvements.
eps1lon
reviewed
Feb 8, 2021
oliviertassinari
force-pushed
the
slider-touch-event
branch
3 times, most recently
from
e0d155c to
a65cdd1
Compare
Member
|
@eps1lon I have fixed your new test case, as well as on the Select component (both were indeed having a global side effect). I believe that the current tradeoff delivers. |
oliviertassinari
force-pushed
the
slider-touch-event
branch
from
a65cdd1 to
cd81055
Compare
oliviertassinari
force-pushed
the
slider-touch-event
branch
from
cd81055 to
89b3459
Compare
eps1lon
changed the title
eps1lon
changed the title
eps1lon
previously requested changes
Feb 9, 2021
packages/material-ui-unstyled/src/SliderUnstyled/SliderUnstyled.js
Outdated
Show resolved
Hide resolved
eps1lon
previously requested changes
Feb 11, 2021
oliviertassinari
force-pushed
the
slider-touch-event
branch
2 times, most recently
from
72432cb to
0b4cf39
Compare
This reverts commit 4085c25.
oliviertassinari
force-pushed
the
slider-touch-event
branch
from
0b4cf39 to
8050e5d
Compare
Member
|
@praveenkumar-kalidass Thanks for the work! |
eps1lon
added
breaking change
This was referenced Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Clones the event if it is a native event.
Why is it needed?
Not cloning the native event leads to event leaks to its parent.
Related issue(s)/PR(s)
Closes #24740