[lab] Reflect draft pattern of picker value in implementation #24367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
performance
component: DatePicker
oliviertassinari
removed
component: DateRangePicker
eps1lon
added
component: DateTimePicker
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
eps1lon
force-pushed
the
fix/lab-pickers-on-change
branch
from
9f5c508 to
e8aef2a
Compare
Member
Author
|
Went over this again and again. Worst case scenario is that it will reveal some code that relies on cascading updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #24366 (diff)
I originally misidentified that
usePickerStateneedsgetDerivedStateFromProps. I believe now thatusePickerStateimplements the draft pattern but the previous implementation useduseEffect. However, that pattern can be implemented without needing to commit twice. The React docs go over this in more detail: https://reactjs.org/blog/2018/06/07/you-probably-dont-need-derived-state.html#recap (look for usage of "draft").We still have cascading updates (https://mui-dashboard.netlify.app/test-profile/212342/details/%3CDatePicker%20%2F%3E%20render%20proper%20month).
Latest
test_profileonnext: https://mui-dashboard.netlify.app/test-profile/212357Latest
test_profileon this PR: https://mui-dashboard.netlify.app/test-profile/212342