[Pickers] Rework keyboard navigation implementation #24315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/lab: parsed: -0.06% 😍, gzip: -0.15% 😍 |
This was referenced Jan 8, 2021
github-actions
bot
added
the
PR: out-of-date
eps1lon
force-pushed
the
fix/lab/pickers-gdsfp
branch
from
9dd7afc to
64f02f0
Compare
github-actions
bot
removed
the
PR: out-of-date
eps1lon
changed the title
eps1lon
force-pushed
the
fix/lab/pickers-gdsfp
branch
from
7fa5485 to
30039ca
Compare
eps1lon
force-pushed
the
fix/lab/pickers-gdsfp
branch
2 times, most recently
from
efd8e03 to
67d9eef
Compare
eps1lon
force-pushed
the
fix/lab/pickers-gdsfp
branch
from
67d9eef to
760c953
Compare
eps1lon
changed the title
eps1lon
added
scope: pickers
eps1lon
force-pushed
the
fix/lab/pickers-gdsfp
branch
from
143fd09 to
9487537
Compare
2 tasks
Member
|
@eps1lon oops, sorry for the delay, I will dive into this one tomorrow |
Member
Author
All good. I have quite the backlog myself so this will have two sets of fresh eyes 😉 |
eps1lon
force-pushed
the
fix/lab/pickers-gdsfp
branch
from
fcda0aa to
f64e37e
Compare
tchock
added a commit
to Bojagi/material-ui
that referenced
this pull request
Feb 16, 2021
This is a copy of upstream PR mui#24315
tchock
added a commit
to Bojagi/material-ui
that referenced
this pull request
Feb 16, 2021
This is a copy of upstream PR mui#24315
tchock
added a commit
to Bojagi/material-ui
that referenced
this pull request
Feb 16, 2021
This is a copy of upstream PR mui#24315
Member
Author
|
Merging since this simplifies the implementation considerably. I'd like to get this in as well as click-away fixes until monday. |
oliviertassinari
changed the title
tchock
added a commit
to Bojagi/material-ui
that referenced
this pull request
Mar 10, 2021
This is a copy of upstream PR mui#24315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should not change "intended" keyboard navigation. Its goal is to simplify focus managment and re-use existing patterns.
It's unclear why we need global event handlers. The only focusable items in the collection are the individual days/years so we might as well attach the listener to these elements directly. React takes care of event delegation.
useCanAutoFocusSeems to me this works just as well by assuming that "button isMounted? => canAutoFocus"
Manual testing:
test_profile baseline Analysis: https://mui-dashboard.netlify.app/test-profile/225337
test_profile PR Analysis: https://mui-dashboard.netlify.app/test-profile/225317