mt-download-data.yml> trigger mt-sync-code-data.yml if current data is outdated & newer data vailable

[mmathieum]

Following:

• Auto-trigger data sync when archive contains newer data than deployed #537

Solving:

• mt-download-data.yml > trigger mt-sync-code-data.yml if new data and data available outdated #482

[gemini-code-assist]

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the data freshness check within the check_data_outdated.sh script. The core change involves inverting the logic for determining if deployed data is outdated, ensuring that a data synchronization workflow is only triggered when the current data has genuinely expired. This enhancement aims to improve the accuracy of data status reporting and prevent unnecessary synchronization operations.

Highlights

• Data Outdated Logic Inversion: The check_data_outdated.sh script's logic for determining if deployed data is outdated has been inverted. Previously, it checked if the last departure was in the past; now, it first checks if it's in the future.
• Early Exit for Fresh Data: The script now includes an early exit with code 0 if the deployed data's last departure timestamp is in the future, indicating the data is not outdated and no synchronization is needed.
• Outdated Data Handling Refinement: If the data's last departure is in the past or present, the script now proceeds to explicitly declare the data outdated, recommend a sync, and initiate the search for available archives.

Changelog

• shared-opt-dir/agency-parser/check_data_outdated.sh
  • Modified the conditional check for data freshness, now explicitly checking if deployed data is not outdated (i.e., last departure is in the future) and exiting with 0 in that case.
  • Updated log messages to align with the new logic, clearly indicating when data is considered not outdated versus expired.
  • Ensured that the "data outdated" message and subsequent archive search are executed only when the deployed data's last departure is in the past or present.

Activity

• The pull request is authored by mmathieum.
• This change is a follow-up to pull request Auto-trigger data sync when archive contains newer data than deployed #537.
• This pull request addresses and solves issue mt-download-data.yml > trigger mt-sync-code-data.yml if new data and data available outdated #482.
• No specific review comments or interactions have been recorded yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the check_data_outdated.sh script to improve the logic for determining if a data sync is necessary. The change correctly adds an early exit if the deployed data has not yet expired, which is a good improvement. However, I've found a small bug in the calculation of the remaining time for non-expired data, along with a typo in an associated log message. My review includes a suggestion to fix these issues.