Service updates/alerts compat w/ trip IDs

[mmathieum]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial Android permission to the application's manifest generation script. This permission is necessary for the application to read module data, which is a foundational step towards enabling compatibility for service updates and alerts that are linked to specific trip IDs. The change ensures the application has the required access rights to support this new functionality.

Highlights

• Android Permissions: A new uses-permission tag for ${permission_provider_read} has been added to the Android manifest generation script.
• Module Data Access: This permission is explicitly noted as "required to read modules data", enabling the application to access necessary information.
• Service Compatibility: This change facilitates compatibility for service updates and alerts with trip IDs, as indicated by the pull request title.

Changelog

• shared-modules/app-android/src/main/MTAndroidManifest.xml.MT.sh
  • Added a uses-permission entry for ${permission_provider_read} to allow reading of module data.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to add a new permission to the AndroidManifest.xml file, which is generated by a shell script. My review identified a critical issue where a shell variable is not properly escaped. This would likely result in an invalid manifest file and cause the build to fail. I have provided a code suggestion to rectify this.

[Copilot]

Pull request overview

Adds a provider read permission declaration to the Android manifest template to support updated service updates/alerts behavior.

Changes:

• Declares a new <uses-permission> entry using the ${permission_provider_read} manifest placeholder in the generated manifest.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.