-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python dependency upper bound #74
Milestone
Comments
yajo
added a commit
to copier-org/copier
that referenced
this issue
Jan 15, 2024
To do so, it required to add the `python_version < 4` marker to dependencies that still use upper bound markers. I opened mtkennerly/dunamai#74 to the only relevant one. In the case of poetry-dynamic-versioning, it's just a build-time dependency, so I don't really care it has that marker, as long as I build using Python 3.
yajo
added a commit
to copier-org/copier
that referenced
this issue
Jan 16, 2024
To do so, it required to add the `python_version < 4` marker to dependencies that still use upper bound markers. I opened mtkennerly/dunamai#74 to the only relevant one. In the case of poetry-dynamic-versioning, it's just a build-time dependency, so I don't really care it has that marker, as long as I build using Python 3.
While I don't agree with that article's points about Semantic Versioning, I do agree that:
While doing some research, I also found these discussions helpful:
I'll relax the bounds to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Python dependency has an upper bound:
dunamai/pyproject.toml
Line 24 in 8a16c30
https://iscinumpy.dev/post/bound-version-constraints/ explains why this is bad.
Would you mind to please remove that and just use
python = ">=3.5"
?Thanks!
The text was updated successfully, but these errors were encountered: