Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add "application/protobuf" handling test #1443

Merged
merged 3 commits into from
Nov 16, 2023
Merged

test: add "application/protobuf" handling test #1443

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bded29e
test: added (currently broken) protobuf parsing test
Oct 22, 2022
30027a2
Merge branch 'main' into issue/1442-corrupted-request-body
kettanaito Nov 14, 2023
b5f5080
Merge branch 'main' into issue/1442-corrupted-request-body
kettanaito Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions test/node/rest-api/request/body/body-protobuf.node.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// @vitest-environment node
import { http, HttpResponse } from 'msw'
import { setupServer } from 'msw/node'

const server = setupServer(
http.post('https://example.com/protobuf', async ({ request }) => {
const buffer = await request.arrayBuffer()

return new HttpResponse(new Uint8Array(buffer), {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DGollings, hi 👋 Do you think it's necessary to preserve this conversion here or should be simply forward the buffer as-is to the response? It'd also change how we assert the actual response body sent back.

In any case, the test is now passing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't remember why that conversion is there, maybe to be slightly more realistic to actual usage? You generally don't respond with the exact request as-is (I think? Its been over a year)

headers: {
'Content-Type': 'application/protobuf',
},
})
}),
)

beforeAll(() => {
server.listen()
})

afterAll(() => {
server.close()
})

it('responds with a "application/protobuf" mocked response', async () => {
const payload = new Uint8Array([138, 1, 6, 10, 4, 10, 2, 32, 1])

const response = await fetch('https://example.com/protobuf', {
method: 'POST',
headers: {
'Content-Type': 'application/protobuf',
},
body: payload,
})
const body = await response.arrayBuffer()

expect(new Uint8Array(body)).toEqual(payload)
})
Loading