test: add "application/protobuf" handling test #1443
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bded29e:
|
|
We need to re-assess this test in the context of the recent MSW 2.0 release. I have a suspicion that this will no longer be an issue. I will rebase the branch and let's see. |
| http.post('https://example.com/protobuf', async ({ request }) => { | ||
| const buffer = await request.arrayBuffer() | ||
|
|
||
| return new HttpResponse(new Uint8Array(buffer), { |
There was a problem hiding this comment.
@DGollings, hi 👋 Do you think it's necessary to preserve this conversion here or should be simply forward the buffer as-is to the response? It'd also change how we assert the actual response body sent back.
In any case, the test is now passing.
There was a problem hiding this comment.
I honestly don't remember why that conversion is there, maybe to be slightly more realistic to actual usage? You generally don't respond with the exact request as-is (I think? Its been over a year)
kettanaito
changed the title
Released: v2.0.7 🎉This has been released in v2.0.7! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Added test which mimicks the behaviour I see in issue #1442
Simply returns the request, which should remain completely unchanged whilst moving through msw