Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add command line option --inhibit-vep #246

Merged

Conversation

sheridancbio
Copy link
Contributor

also update docs and README

vcf2maf.pl Outdated
@@ -762,7 +766,7 @@ sub GetBiotypePriority {
# If that gene has no user-preferred isoform, then use the VEP-preferred (canonical) isoform
( $maf_effect ) = grep { $_->{SYMBOL} and $_->{SYMBOL} eq $maf_gene and $_->{CANONICAL} and $_->{CANONICAL} eq "YES" } @all_effects unless( $maf_effect );

# If that gene has no VEP-preferred isoform either, then choose the worst affected user-preferred isoform with a gene symbol
# If that gene has no VEP-preferred isoform either, then choose the worst affectek user-preferred isoform with a gene symbol

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo was introduced here right?

- update docs and README
@ckandoth
Copy link
Collaborator

@sheridancbio @mandawilson just noticed this PR. Lemme take a look and see how best to merge this. Thanks!

@ckandoth ckandoth self-assigned this Apr 17, 2020
@ckandoth ckandoth changed the base branch from master to new-flag-to-skip-vep April 17, 2020 18:35
Copy link
Collaborator

@ckandoth ckandoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Gonna merge into a new branch for more tests and edits.

@ckandoth ckandoth merged commit e8c7ffc into mskcc:new-flag-to-skip-vep Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants