Repository navigation
chore(frontend): remove orphaned duplicate singletons ObserverPatterns + CacheManager (#12103, #12104) - #12123
Merged
Merged
Conversation
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12103
Closes #12104
Part of #11682
Thinking Path
Owner rule for orphans: if it's a duplicate already replaced with no functionality lost → remove; otherwise wire in. Both qualify for removal (verified 0 imports, 0 named-export usage, no .d.ts, no barrel re-export):
eventObserver/stateObserver+ 6 exports): pub-sub is already provided by the canonicaluseEventBus(subscribe/unsubscribe) +LiveEventService; state-watch by the 11 Pinia stores. Duplicate of already-replaced functionality, 0 consumers → no loss.cacheManagerbrowser-cache clearing): superseded byCacheBuster.js(wired into App.vue'sclearAllCaches). Duplicate, 0 call-sites → no loss.(The 3rd orphan, AdvancedControlApiClient #12102, is NOT removed — its backend routes are live and it's the client for the #11506 desktop-takeover feature; it needs wiring in, tracked separately.)
Verification
Zero imports of either file / their named exports across src (grep incl .d.ts, barrels, dynamic). No references remain post-removal. Build-safe (nothing depended on them).
Model Used
Claude Opus 4.8
EOF
)