Repository navigation
fix(audit): display routable host instead of bind-all 0.0.0.0 in audit dashboard (#10502 #11) - #10854
Merged
Merged
Conversation
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
Live re-triage of #10502's 11 defects found 8 already fixed since the 2026-06-26 triage and 3 runtime/data (not code). Only item #11 was a real code bug: the audit dashboard shows the backend's bind address (
config.vm.main=AUTOBOT_BACKEND_HOST, set to0.0.0.0in prod) as if it were the host.What Changed
services/audit_logger.py: newdisplay_hostproperty — returns the machine FQDN/hostname whenvm_sourceis a bind-all/loopback placeholder (0.0.0.0,::,127.0.0.1,::1,localhost, empty), else the configured value unchanged. Module-level_NON_ROUTABLE_HOSTSset.socketalready imported.api/audit.py: audit-statisticsvm_info.vm_sourcenow returnsdisplay_host(backend-only; no frontend/type change — the label already renders this field).Verification
python -m py_compileclean on both files.0.0.0.0/empty → resolved FQDN; a real IP (10.0.0.5) passes through untouched.Model Used
Claude Opus 4.8 (1M context)
Closes #10502 — item #11 is the final code-actionable defect; #1-#5,#7,#8 were already fixed since the 2026-06-26 triage and #6/#9/#10 are runtime/data (not code), per the detailed re-triage comment on the issue.