Repository navigation
Conversation
mrveiss
commented
Aug 15, 2025
mrveiss
commented
Owner
- Executive summary and priority task breakdown
- Security, performance, and architecture assessments
- Code quality metrics and improvement recommendations
- Technical debt analysis and remediation roadmap
- Executive summary and priority task breakdown - Security, performance, and architecture assessments - Code quality metrics and improvement recommendations - Technical debt analysis and remediation roadmap
Closed
13 tasks
mrveiss
added a commit
that referenced
this pull request
Apr 3, 2026
…Context7 gaps Each file title mirrors the exact Context7 test query to maximise RAG retrieval: - execute-bash-command-target-group-linux-nodes-slm.md (#1, 97) Single-node POST /nodes/{id}/execute + parallel asyncio.gather group script + distributed_shell workflow step - configure-autobot-chat-local-ollama-instance.md (#2, 96) Env vars AUTOBOT_OLLAMA_ENDPOINT/HOST/MODEL + admin PUT /settings/admin/llm + fleet apply via Ansible + model routing GPU vs CPU - codebase-analytics-api-coverage-report.md (#4, 97) Source registration + indexing job polling + /endpoint-coverage report shape + orphaned/missing endpoint endpoints - rag-workflow-pdf-repository-context.md (#5, 97) PDF upload via /knowledge_base/upload + ChromaDB storage + automatic chat RAG + direct /knowledge_search/rag_search + custom pipeline example - vision-module-vnc-detect-click-button.md (#6, 94) /vnc/screenshot + /vision/analyze UIElement structure + /vnc/click + form fill test script + detection techniques reference - distributed-execution-failover-redis-worker-nodes.md (#10, 97) Redis ZSET/SET key schema + failover_monitor config + priority enqueue + exponential backoff + test script + Celery routing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 of 6 tasks
5 tasks
mrveiss
added a commit
that referenced
this pull request
May 23, 2026
) - _assert_prefix_unique: add deleted_at IS NULL guard so soft-deleted orgs no longer permanently poison their issue_prefix slot (#5) - CompanyUpdate: remove llc_status field — callers must use dedicated suspend()/archive() methods to enforce transition guards (#6) - API handlers: add session.rollback() in all except branches and a bare Exception fallback to keep the connection pool clean on IntegrityError and other unexpected failures (#7) - delete endpoint: catch CompanyHasChildrenError → 409 with rollback (#7) - suspend()/archive(): add state transition matrix — suspend only from ONBOARDING/ACTIVE, archive only from PAUSED/OFFBOARDING; raises ValueError on invalid transition (#8) - get_ancestry: chain.append + chain.reverse() instead of insert(0), eliminating O(n²) list-copy on deep hierarchies (#9) - _build_tree_node: asyncio.gather children instead of sequential await, reducing tree fetch to O(depth) round-trips (#10) Co-authored-by: Paperclip <noreply@paperclip.ing>
This was referenced May 24, 2026
mrveiss
added a commit
that referenced
this pull request
Jun 26, 2026
…ty-analytics empty-state (#10502) (#10506) #5 Company OS 503 in single_user: backend now emits company_os_enabled (=postgres_enabled) in /frontend-config features; a reactive useRuntimeFeaturesStore consumes it to hide the Company OS nav item and render an informational empty-state in CompanySelectorView instead of a raw 503 + Retry. The view no longer fetches companies when disabled. #7 Live Activity Feed froze on first load: the poll ran a synthetic simulateActivity() instead of re-fetching. Now each tick re-fetches real recent tasks + agent status; events sort newest-first; default interval 20s. #8 Knowledge Base rendered key-name stubs ("Title"/"Subtitle"/...): the knowledge.search.* block was auto-stubbed. Replaced with real English text across all locale files (parity preserved). #10 Security Analytics looked broken ("No Services"/"Not Configured"): show a graceful setup guide (provider config steps + settings link) when no threat-intel provider is configured, instead of the empty dashboard. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
3 tasks
mrveiss
added a commit
that referenced
this pull request
Sep 29, 2026
…space (#17580) Two review findings, both this issue's own subject. ## The colon form, established from GitHub's documentation Not assumed -- the gates exist to mirror the platform, so the platform is the test. GitHub's docs: "The keywords can be followed by colons or in uppercase. For example: `Closes: #10`, `CLOSES #10`, or `CLOSES: #10`." Both gates required whitespace IMMEDIATELY after the keyword (`\s+` in `_CLOSING`/`_REFERENCE`/`_LINE_START_CLOSING`, `[[:space:]]+` in the workflow's link check and fork override). So `Fixes: #123` closed the issue on merge while the link gate rejected the PR for having no linkage and the batching count omitted it -- a batch never asked for its rationale, and a PR that genuinely links told it had not. That is the same divergence this issue exists to remove, in the opposite direction from the missing inflections: there the gates saw no reference where GitHub saw one; here they see none where GitHub CLOSES. Fixed with an optional `:?` in all five patterns, after the keyword and inside the existing left boundary. The boundary is not weakened by it: `unresolved: #1234`, `prefixes: #12345`, `we disclose: #5` and `self-closes: #8` are all still non-references, pinned as fixtures. `Closes:#10` -- colon with no following space -- is left REJECTED and asserted as such. The docs say "followed by colons" and every example they give has a space; they do not say whether the space is required. So the conservative pattern stands and the choice is visible in a test that fails if someone changes it, rather than being an unwritten accident. ## Mid-sentence detection counted issue numbers, not occurrences `mid_sentence_closings` was `closing_issues(body) - _issues_under(body, _LINE_START_CLOSING)`. For Closes #42 This does not close #42 both sides contain "42", the difference is empty, and `check()` omits the warning. The body most likely to be a real mistake was the one silently exempt, because the same number also appeared in a deliberate declaration. Both patterns capture the reference run as group 1, so `start(1)` is the same offset for the same occurrence under either. An occurrence whose run is not at a declared line start is mid-sentence, whatever else the body says about that issue. ## One of my own new tests could not fail, and was replaced The first version of the colon-shape test asserted `"10" in closing_issues(body) or closing_issues(body) == set()`, which passes whichever way the gate behaves. I wrote it that way because I had not established the no-space case -- but an assertion that accepts both outcomes records nothing, which is the shape the rest of this file exists to catch. Split into a real assertion for the documented forms and a stated gap for the undocumented one. ## Mutation-checked drop the optional colon -> 14 failed (nine keywords plus five author shapes) revert to the set difference -> exactly the 2 both-ways tests, by name Verified: keywords suite 61 passed; with `check_pr_issue_batching_test.py` 127 passed; flake8 clean. The third review thread is stale: it reports the fork-override path as knowing only `resolves|closes|fixes`, which was fixed in the previous commit -- that line carries all nine and the boundary. Resolved on the thread with the current text rather than changed again. Refs #17580
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.