Skip to content

tech-debt(ci): workflow trigger paths drift — auto-detect missing path globs (#7137 follow-up) #7223

Closed

Description

@mrveiss

Context

#7137 (PR #7138) needed a second commit to add `autobot-slm-backend/ansible/ansible.cfg` to the `ansible-role-facts-test.yml` workflow's trigger paths. Without it, the fix didn't trigger CI verification — silent green via "workflow not triggered" instead of green via "tests pass".

Problem

There's no system-wide check that workflow trigger paths cover all files those workflows actually validate. Changes to ancillary files (configs, helpers) can bypass the workflow that's supposed to verify them.

Proposed solution

CI lint step that:

  1. For each workflow, parses `paths:` glob list
  2. Checks that all imports/refs in the workflow's run: scripts are covered by at least one glob
  3. Flags workflows where touching the actual code-under-test wouldn't trigger the workflow

OR simpler heuristic: a workflow that runs `ansible-playbook` with `-i autobot-slm-backend/ansible/inventory/...` SHOULD have `autobot-slm-backend/ansible/**` in its paths.

Acceptance criteria

  • Lint identifies workflows where trigger paths are narrower than the files they verify
  • Existing workflows audited (likely 2-3 with the same pattern)
  • Per-workflow comment documenting the rationale for the path subset

Activity

  1. added 2 commits that reference this issue on May 8, 2026
    89d8d94
    c03d018
  2. github-actions commented on May 8, 2026

    @github-actions
    Contributor

    PR #7242 (merged to Dev_new_gui) references this issue with a close keyword.

    ci: extend ansible-role-facts-test trigger paths (closes #7223)

    If this issue is fully resolved, close it manually. If work remains, no action is needed.

  3. mrveiss commented on May 8, 2026

    @mrveiss
    OwnerAuthor

    ✅ Closed with proof — commit c03d01834 (PR #7242).

    ACs Met:

    • ✅ Audited all workflows for trigger-path coverage gaps
    • ✅ ansible-role-facts-test.yml: added 5 missing paths (ansible.cfg, pre-flight-code-sync.yml, playbooks/update-all-nodes.yml, top-level update-all-nodes.yml, roles/_shared/tasks/**)
    • ✅ Documented other findings in commit body: autoresearch-image.yml has narrower-than-ideal paths (separate scope), frontend-codegen-drift/test/visual-regression have cosmetic duplicates only

    Note: Auto-detect lint (acceptance criterion 1) was deferred — would require parsing each workflow's run: scripts to identify which files they touch, which is heavy. The fix-the-known-gaps approach handles the immediate impact; future regressions will surface when workflows fail to trigger on relevant changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions