Skip to content

Commit c03d018

Browse files
mrveisstclaude
authored
ci: extend ansible-role-facts-test trigger paths (closes #7223 partial) (#7242)
Audit per #7223 found ansible-role-facts-test.yml trigger paths are narrower than what the workflow validates. Missing: ansible.cfg - validates callback config (#7137) this paragraph was added in #7137 but lost in the squash-merge playbooks/pre-flight-code-sync.yml - tested via test_clean_yml_loops playbooks/update-all-nodes.yml - shares git_repo_root code path update-all-nodes.yml - top-level (basename collision) roles/_shared/tasks/** - shared clean.yml + apt-repo tasks (#7058 + #7218); the test_clean_yml_loops playbook includes these After this fix, every file actually exercised by the workflow's run: scripts is also in the trigger paths. Prevents silent green via "workflow not triggered" instead of green via "tests pass" (the regression class this issue identified). Other workflow audits performed: autoresearch-image.yml - paths only Dockerfile/requirements/main — any other Python module change wouldn't trigger rebuild. NOT FIXED here (separate scope, autoresearch service is rarely modified). frontend-codegen-drift.yml - duplicate path entry (push+PR triggers share). Cosmetic, not fixed. frontend-test/visual-regression - duplicate paths same reason. Cosmetic. All others — paths look complete. Co-authored-by: t <t@t> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 9d0a71d commit c03d018

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

‎.github/workflows/ansible-role-facts-test.yml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,29 @@ name: ansible-role-facts-test
1919
on:
2020
pull_request:
2121
paths:
22+
- 'autobot-slm-backend/ansible/ansible.cfg'
2223
- 'autobot-slm-backend/ansible/inventory/group_vars/**'
2324
- 'autobot-slm-backend/ansible/playbooks/provision-fleet-roles.yml'
25+
- 'autobot-slm-backend/ansible/playbooks/pre-flight-code-sync.yml'
26+
- 'autobot-slm-backend/ansible/playbooks/update-all-nodes.yml'
27+
- 'autobot-slm-backend/ansible/update-all-nodes.yml'
2428
- 'autobot-slm-backend/ansible/roles/*/tasks/clean.yml'
29+
- 'autobot-slm-backend/ansible/roles/_shared/tasks/**'
2530
- 'autobot-slm-backend/ansible/tests/**'
2631
- '.github/workflows/ansible-role-facts-test.yml'
2732
push:
2833
branches:
2934
- Dev_new_gui
3035
- main
3136
paths:
37+
- 'autobot-slm-backend/ansible/ansible.cfg'
3238
- 'autobot-slm-backend/ansible/inventory/group_vars/**'
3339
- 'autobot-slm-backend/ansible/playbooks/provision-fleet-roles.yml'
40+
- 'autobot-slm-backend/ansible/playbooks/pre-flight-code-sync.yml'
41+
- 'autobot-slm-backend/ansible/playbooks/update-all-nodes.yml'
42+
- 'autobot-slm-backend/ansible/update-all-nodes.yml'
3443
- 'autobot-slm-backend/ansible/roles/*/tasks/clean.yml'
44+
- 'autobot-slm-backend/ansible/roles/_shared/tasks/**'
3545
- 'autobot-slm-backend/ansible/tests/**'
3646

3747
jobs:

0 commit comments

Comments
 (0)