Skip to content

rescued stash: mva-180-validate-run-jwt-aud-claim: b4dda9553 fix(security): enforce aud claim in validate #14096

Closed

Description

@mrveiss

Child of #14078. The work is safe — it is now a branch on origin, not only a stash entry.

Branch rescued/stash-2026-05-12-f6fd80143
Stash commit f6fd80143ca533818110289a4e5e6775aca7e809
Stashed 2026-05-12
Change 7 files changed, 305 insertions(+), 350 deletions(-)
Applies to current base CONFLICTED
Original context mva-180-validate-run-jwt-aud-claim: b4dda95 fix(security): enforce aud claim in validate

Files touched:

  • autobot-frontend/src/composables/useAuditApi.ts
  • autobot-frontend/src/composables/useBatchProcessing.ts
  • autobot-frontend/src/composables/useOperationsApi.ts
  • autobot-frontend/src/composables/useProbeBackedHealth.ts
  • autobot-frontend/src/composables/useSecretsAuditApi.ts
  • autobot-frontend/src/composables/useServiceMessages.ts
  • autobot-frontend/src/views/LLMApiKeysView.vue

Why this exists: the repo-wide stash stack held 113 entries spanning three months, unowned and
unlinked. This one's content is absent from Dev_new_gui — verified by git apply --check --3way
— so it is genuinely unfinished work, not a leftover of something that already landed.

Ask — a decision, not a deletion:

  1. Is this work still wanted? The original context above names where it came from (MVA-180 discovery(security): validate_run_jwt does not verify aud claim — heartbeat token accepted by any validator #7643 ).
  2. Wanted → rebase rescued/stash-2026-05-12-f6fd80143 onto Dev_new_gui, open a PR, land it.
  3. Not wanted → say so here with the reason, then delete the branch. A recorded decision, never a
    silent drop.

Note: this one does not apply cleanly to today's base — expect a real rebase, not a fast-forward.

Activity

  1. mrveiss commented on Aug 25, 2026

    @mrveiss
    OwnerAuthor

    Disposition: LANDED

    The stash migrates six composables off the deprecated useApiWithState() from @/composables/useApi
    onto useApiClient() from @/plugins/api, with showSubtleErrorNotification for error surfacing.

    Evidence

    Base composable useApiClient present
    useAuditApi.ts yes
    useBatchProcessing.ts yes
    useOperationsApi.ts yes
    useProbeBackedHealth.ts yes
    useSecretsAuditApi.ts yes — imports are line-for-line what the stash was writing, showSubtleErrorNotification included
    useServiceMessages.ts yes

    Landing commit: 89dc98b105 — refactor(frontend): complete useApiWithState Group 3 composables
    migration (#7600)
    , 2026-05-15, three days after this stash was taken. No file under
    autobot-frontend/src imports useApi / useApiWithState any more.

    The seventh file, src/views/LLMApiKeysView.vue, no longer exists at that path: it moved in
    f10ba88eb9 feat(secrets): move LLM API Keys into the Secrets menu (#10488) (#10568) and is now
    src/views/secrets/LlmApiKeysView.vue.

    Parent issues MVA-180 / #7643 are CLOSED.

    Decision: landed. rescued/stash-2026-05-12-f6fd80143 is disposable; left in place — branch
    deletion is a separate deliberate act.

    Discovered while checking this — filed separately: autobot-frontend/src/composables/useApi.ts
    still exists and still exports useApiWithState, with zero importers left in src/. The #7600
    migration retired every call site but not the shim.

  2. mrveiss commented on Aug 25, 2026

    @mrveiss
    OwnerAuthor

    Filed the leftover useApi.ts shim noted above as #15025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions