Skip to content

rescued stash: fix-vue-tsc-baseline-251-local: 8210b024c fix(ci): fix import sorting with isort #14086

Closed

Description

@mrveiss

Child of #14078. The work is safe — it is now a branch on origin, not only a stash entry.

Branch rescued/stash-2026-06-05-0d711d576
Stash commit 0d711d57682a13f411364ce41cba99c9fee15286
Stashed 2026-06-05
Change 10 files changed, 13 insertions(+), 27 deletions(-)
Applies to current base CONFLICTED
Original context fix-vue-tsc-baseline-251-local: 8210b02 fix(ci): fix import sorting with isort

Files touched:

  • autobot-backend/api/batch_jobs.py
  • autobot-backend/api/vision.py
  • autobot-backend/operator_dashboard/gmail_service.py
  • autobot-backend/services/transcript_export/docx_exporter.py
  • autobot-backend/services/transcript_export/pdf_exporter.py
  • autobot-backend/services/transcript_export/srt_exporter.py
  • autobot-backend/services/transcript_export/vtt_exporter.py
  • autobot-backend/skills/external_importer.py
  • autobot-backend/transcriber/routes/ai.py
  • autobot-backend/utils/helpers_reorganization_test.py

Why this exists: the repo-wide stash stack held 113 entries spanning three months, unowned and
unlinked. This one's content is absent from Dev_new_gui — verified by git apply --check --3way
— so it is genuinely unfinished work, not a leftover of something that already landed.

Ask — a decision, not a deletion:

  1. Is this work still wanted? The original context above names where it came from.
  2. Wanted → rebase rescued/stash-2026-06-05-0d711d576 onto Dev_new_gui, open a PR, land it.
  3. Not wanted → say so here with the reason, then delete the branch. A recorded decision, never a
    silent drop.

Note: this one does not apply cleanly to today's base — expect a real rebase, not a fast-forward.

Activity

  1. mrveiss commented on Aug 25, 2026

    @mrveiss
    OwnerAuthor

    Disposition: LANDED in part, SUPERSEDED in part, OBSOLETE in part — nothing left to land

    Ten files, checked one by one against origin/Dev_new_gui:

    File Verdict Evidence
    api/batch_jobs.py (drop unused BatchJobsHealthResponse) LANDED zero occurrences of the symbol in base's batch_jobs.py
    utils/helpers_reorganization_test.py (drop 18 duplicate import os) LANDED base has zero top-level import os lines in that file
    api/vision.py (drop unused VisionHealthResponse) OBSOLETE — and now wrong base uses it: vision.py:345 @router.get("/health", response_model=VisionHealthResponse). Applying the stash would break the health endpoint
    skills/external_importer.py (move the codeql[py/full-ssrf] suppression above the call) SUPERSEDED base already carries the suppression on its own preceding comment block, with a fuller justification and an issue link (external_importer.py:328-330, #12278)
    operator_dashboard/gmail_service.py (split a bogus f"…" f"…" concat) OBSOLETE — code gone the raise ValueError("Gmail credentials are invalid…") block no longer exists in base
    services/transcript_export/{docx,pdf,srt,vtt}_exporter.py OBSOLETE — path gone package removed by e97e4882c3 (#9958) (#10229); transcriber/export/ is the surviving implementation
    transcriber/routes/ai.py LANDED the added line is present verbatim in base

    Decision: every hunk is either already in base, moot because the file is gone, or actively
    harmful now (the vision.py import is live). Nothing to rebase.

    rescued/stash-2026-06-05-0d711d576 is disposable; left in place — branch deletion is a separate
    deliberate act.

  2. mrveiss commented on Aug 25, 2026

    @mrveiss
    OwnerAuthor

    Disposition: LANDED in part, SUPERSEDED in part, OBSOLETE in part — nothing left to land

    Ten files, checked one by one against origin/Dev_new_gui:

    File Verdict Evidence
    api/batch_jobs.py (drop unused BatchJobsHealthResponse) LANDED zero occurrences of the symbol in base's batch_jobs.py
    utils/helpers_reorganization_test.py (drop 18 duplicate import os) LANDED base has zero top-level import os lines in that file
    api/vision.py (drop unused VisionHealthResponse) OBSOLETE — and now wrong base uses it: vision.py:345 @router.get("/health", response_model=VisionHealthResponse). Applying the stash would break the health endpoint
    skills/external_importer.py (move the codeql[py/full-ssrf] suppression above the call) SUPERSEDED base already carries the suppression on its own preceding comment block, with a fuller justification and an issue link (external_importer.py:328-330, #12278)
    operator_dashboard/gmail_service.py (split a bogus f"…" f"…" concat) OBSOLETE — code gone the raise ValueError("Gmail credentials are invalid…") block no longer exists in base
    services/transcript_export/{docx,pdf,srt,vtt}_exporter.py OBSOLETE — path gone package removed by e97e4882c3 (#9958) (#10229); transcriber/export/ is the surviving implementation
    transcriber/routes/ai.py LANDED the added line is present verbatim in base

    Decision: every hunk is either already in base, moot because the file is gone, or actively
    harmful now (the vision.py import is live). Nothing to rebase.

    rescued/stash-2026-06-05-0d711d576 is disposable; left in place — branch deletion is a separate
    deliberate act.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions