You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Surfaced by #12441 (masked by conftest services MagicMock stub) — triage needed
Real-loading services.* submodules (PR #12441, #12438) unmasked these test failures. Each is either real behavior-drift OR a stale test expectation — triage + fix per module (none out of scope). Assertion details:
redis_service_manager_slm_test.py (4):
TestInit::test_defaults_from_env — slm_url resolves to 'http://127.0.0.1:8000', test expects 'https://slm.test' (env-default drift).
TestSlmServiceAction::test_raises_when_no_slm_url — no longer raises.
TestCheckRedisConnectivity ×2 — patch target services.redis_service_manager.get_redis_client but the module has no such attribute (stale patch target → likely test bug).
command_extraction_service_test.py::TestSlmExec::test_returns_false_when_no_slm_url — expects "SLM_URL not configured" in stderr; stderr is ''.
Activity
fix(services): resolve 12 real-load-unmasked test failures across 6 m…
mrveiss commentedon Jul 25, 2026
Fixed in #12448 (merged to Dev_new_gui). Un-masking surfaced 4 real production bugs + 2 stale-test issues across 6 modules: sentinel
""-vs-unset (redis_service_manager, command_extraction), #7437 config-singleton regression (mcp_isolation_config), since-#4167 archive-age-gate bug (notification_suppression), + workflow_io/queue_integration test-infra. 128/128 passing. Follow-up: #12449 (notification_suppression unwired).