OrbitControls: Apply Object's up in runtime #28190
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z4122
force-pushed
the
feat/orbitcontrols_can_change_up_now
branch
from
6aacfc5 to
a071747
Compare
Collaborator
|
This PR actually breaks |
WestLangley
reviewed
Apr 22, 2024
z4122
force-pushed
the
feat/orbitcontrols_can_change_up_now
branch
from
a071747 to
c666427
Compare
Contributor
Author
Sorry for that mistake, please review again |
Mugen87
reviewed
Apr 23, 2024
|
|
||
| // so camera.up is the orbit axis | ||
| quat.setFromUnitVectors( object.up, yAxisUp ); | ||
| quatInverse = quat.clone().invert(); |
Collaborator
There was a problem hiding this comment.
The clone() usage still creates unnecessary instances.
When fixed, the code is actually like #18829. I don't think we need two open PRs for the same thing with essentially the same implementation.
Contributor
Author
There was a problem hiding this comment.
Ok, fixed. Shoud we close this PR, and wait #18829 to merge?
Collaborator
There was a problem hiding this comment.
Yes, I think that is better. I've just rebased #18829 so it can be merged if approved.
z4122
force-pushed
the
feat/orbitcontrols_can_change_up_now
branch
from
c666427 to
e35074c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OrbitControls only set up when init, if user update Object's up, it will not take effect.
This PR update up in runtime.
And I have test it in example. In the beginning, the camera's up is (0, 1, 0), three seconds later, camera's up is (1, 0, 0)
https://github.com/mrdoob/three.js/assets/13222615/d4dca1fb-ca79-46ff-b8f3-d1e1b6d5cbb6
Relevant PR
#18829