OrbitControls: Apply Object's up in runtime

Author: z4122

examples/jsm/controls/OrbitControls.js

@@ -171,11 +171,11 @@ class OrbitControls extends EventDispatcher {
 		// this method is exposed, but perhaps it would be better if we can make it private...
 		this.update = function () {
 
-			const offset = new Vector3();
+			let quat = new Quaternion();
+			let quatInverse = quat.clone().invert();
+			const yAxisUp = new Vector3( 0, 1, 0 );
 
-			// so camera.up is the orbit axis
-			const quat = new Quaternion().setFromUnitVectors( object.up, new Vector3( 0, 1, 0 ) );
-			const quatInverse = quat.clone().invert();
+			const offset = new Vector3();
 
 			const lastPosition = new Vector3();
 			const lastQuaternion = new Quaternion();
@@ -189,12 +189,13 @@ class OrbitControls extends EventDispatcher {
 
 				offset.copy( position ).sub( scope.target );
 
+				// so camera.up is the orbit axis
+				quat = new Quaternion().setFromUnitVectors( object.up, yAxisUp );
+				quatInverse = quat.clone().invert();
+
 				// rotate offset to "y-axis-is-up" space
 				offset.applyQuaternion( quat );
 
-				// angle from z-axis around y-axis
-				spherical.setFromVector3( offset );
-
 				if ( scope.autoRotate && state === STATE.NONE ) {
 
 					rotateLeft( getAutoRotationAngle( deltaTime ) );