OrbitControls: fix Orthographic 'change' event #27424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com>
Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com>
Mugen87
reviewed
Dec 23, 2023
Collaborator
|
The PR indeed fixes the issue! Here is the code I have tested with: https://jsfiddle.net/13Ltqzye/ |
Mugen87
approved these changes
Dec 23, 2023
|
You all rule. Thanks for all you do! |
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
* OrbitControls: fix Orthographic 'change' event Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com> * OrbitControls: only recalculate when zoom has changed Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com> * clean-up Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com> --------- Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27280
Prevents
OrthographicCamerafrom triggeringchangeevent every frame.