OrbitControls update event always fired if using an Orthographic Camera

[jedleslie]

Description

Hi Three Team -

Just ran across this and am not sure if it's an issue or not. I have an app that uses both ortho and perspective cameras along with OrbitControls. I have the OrbitControls update() in my render loop because I am using dampening. I also have an event listener or the change event of OrbitControls.

When I'm in perspective camera, I see the change event being fired only when I'm actually orbiting around the scene. In orthographic mode I see it firing every time the render loop calls update().

Maybe this is by design and part of how ortho cameras need to work. Just though I'd let you know.

Reproduction steps

1. Create a scene and add orthographic and perspective cameras. Add the orbit controls.
2. Add an event handler on the change event for OrbitControls.
3. Swap between the two cameras and watch it fire constantly when in orthographic mode, and only when the orbit controls are firing when in perspective.

Code

// code goes here

Live example

• jsfiddle-latest-release
• jsfiddle-dev

Screenshots

No response

Version

0.158

Device

Desktop

Browser

Chrome

OS

MacOS

[WestLangley]

It appears this behavior was introduced in r155 via #26165.

three.js/examples/jsm/controls/OrbitControls.js

Lines 377 to 379 in 84424e4

	scope.object.zoom = Math.max( scope.minZoom, Math.min( scope.maxZoom, scope.object.zoom / scale ) );
	scope.object.updateProjectionMatrix();
	zoomChanged = true;

zoomChanged is always true.

[Mugen87]

@gkjohnson It seems the mentioned code block was only executed in the dolly/zoom event listeners in previous versions . Now the code is executed per update for orthographic cameras. I'm sure there was a reason for moving the code block but could it be an option to cache the zoom value and only update the projection matrix and set zoomChanged to true when zoom actually changed?