ColorManagement: Add Display P3 transforms #25520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
commented
Feb 17, 2023
Collaborator
Author
|
Added unit tests. I'm using http://www.russellcottrell.com/photo/matrixCalculator.htm to compute the conversion matrices, and https://colorjs.io/ to generate and compare expected values for tests. Color.js is written by co-authors of the CSS Color 4 specification. |
This was referenced Feb 18, 2023
This was referenced Feb 27, 2023
0b5vr
added a commit
to 0b5vr/three-ts-types
that referenced
this pull request
Mar 13, 2023
and `ColorManagement.convert` now supports the `DisplayP3ColorSpace` This commit addresses a part of three-types#357 See: mrdoob/three.js#25520
3 tasks
Methuselah96
pushed a commit
to three-types/three-ts-types
that referenced
this pull request
Mar 24, 2023
and `ColorManagement.convert` now supports the `DisplayP3ColorSpace` This commit addresses a part of #357 See: mrdoob/three.js#25520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Description
Adds
THREE.DisplayP3ColorSpaceconstant, and related CPU-side transforms in THREE.ColorManagement. No rendering code is affected — the only direct effect is thatcolor.getStyle( 'display-p3' )will now apply a conversion.No gamut mapping is applied. Given a Display P3 input that is out-of-gamut for sRGB, conversion to sRGB will yield RGB values outside the range [0, 1]. That is the only lossless choice, which I think is important here, and users can use Color.js or other libraries to select an appropriate gamut mapping method if necessary.
/cc @WestLangley