Skip to content

Commit 852979a

Browse files
committed
feature: add a new constant DisplayP3ColorSpace
and `ColorManagement.convert` now supports the `DisplayP3ColorSpace` This commit addresses a part of three-types#357 See: mrdoob/three.js#25520
1 parent dc73ae3 commit 852979a

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

types/three/src/constants.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,10 +316,11 @@ export enum NormalMapTypes {}
316316
export const TangentSpaceNormalMap: NormalMapTypes;
317317
export const ObjectSpaceNormalMap: NormalMapTypes;
318318

319-
export type ColorSpace = NoColorSpace | SRGBColorSpace | LinearSRGBColorSpace;
319+
export type ColorSpace = NoColorSpace | SRGBColorSpace | LinearSRGBColorSpace | DisplayP3ColorSpace;
320320
export type NoColorSpace = '';
321321
export type SRGBColorSpace = 'srgb';
322322
export type LinearSRGBColorSpace = 'srgb-linear';
323+
export type DisplayP3ColorSpace = 'display-p3';
323324

324325
// Stencil Op types
325326
export enum StencilOp {}

types/three/src/math/ColorManagement.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ColorSpace, LinearSRGBColorSpace, SRGBColorSpace } from '../constants';
1+
import { ColorSpace, DisplayP3ColorSpace, LinearSRGBColorSpace, SRGBColorSpace } from '../constants';
22
import { Color } from './Color';
33

44
export function SRGBToLinear(c: number): number;
@@ -18,8 +18,8 @@ export namespace ColorManagement {
1818

1919
function convert(
2020
color: Color,
21-
sourceColorSpace: SRGBColorSpace | LinearSRGBColorSpace,
22-
targetColorSpace: SRGBColorSpace | LinearSRGBColorSpace,
21+
sourceColorSpace: SRGBColorSpace | LinearSRGBColorSpace | DisplayP3ColorSpace,
22+
targetColorSpace: SRGBColorSpace | LinearSRGBColorSpace | DisplayP3ColorSpace,
2323
): Color;
2424

2525
function fromWorkingColorSpace(color: Color, targetColorSpace: SRGBColorSpace | LinearSRGBColorSpace): Color;

0 commit comments

Comments
 (0)