Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland: use the surface-suspension-v1 protocol #8959

Closed

Commits on Jul 28, 2021

  1. wayland: use the surface-suspension-v1 protocol

    Currently, mpv tries very hard to not do wasteful draws when the surface
    is hidden. This is accomplished by abusing vo_wayland_wait_frame and
    just guessing that consecutive timeouts == surface hidden. This works
    but it's pretty ugly (explaining why wl->timeout_count > 1 is an entire
    novel. Go dig up that commit if you're curious). Luckily, we now have
    the ability to just get suspended events from the compositor. Delete the
    entire timeout/hidden surface heuristic and use the surface_suspended
    and surface_resumed events instead. As a side effect of this, this means
    that mpv will always "overdraw" (i.e. render when not needed) if the
    compositor does not implement this protocol. If this bothers you, go bug
    your compositor developers to fix it and/or switch do a better one.
    Dudemanguy committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    94f242e View commit details
    Browse the repository at this point in the history