wayland: use the surface-suspension-v1 protocol #8959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dudemanguy
force-pushed
the
wayland-surface-suspension
branch
from
f06ef2e
to
98e792a
Compare
|
Sidenote: we could actually be pretty aggressive with this protocol. If we always trust the compositor to tell us when the surface is suspended, then eglSwapInterval could be set to 1 and vulkan's present mode set to FIFO because it would guarantee that the blocking calls would never indefinitely block/stall the player. That would let me delete some more wayland code and simplify it. I probably won't do that the first pass around (that WIP sway implementation is imperfect of course), but in the future this will probably be a hard requirement for mpv to function on wayland. |
Dudemanguy
force-pushed
the
wayland-surface-suspension
branch
3 times, most recently
from
d31c7ac
to
55e74d3
Compare
Currently, mpv tries very hard to not do wasteful draws when the surface is hidden. This is accomplished by abusing vo_wayland_wait_frame and just guessing that consecutive timeouts == surface hidden. This works but it's pretty ugly (explaining why wl->timeout_count > 1 is an entire novel. Go dig up that commit if you're curious). Luckily, we now have the ability to just get suspended events from the compositor. Delete the entire timeout/hidden surface heuristic and use the surface_suspended and surface_resumed events instead. As a side effect of this, this means that mpv will always "overdraw" (i.e. render when not needed) if the compositor does not implement this protocol. If this bothers you, go bug your compositor developers to fix it and/or switch do a better one.
Dudemanguy
force-pushed
the
wayland-surface-suspension
branch
from
55e74d3
to
94f242e
Compare
|
Closing since upstream looks like it'll make this a part of xdg-shell instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of the surface-suspension-v1 protocol for mpv wayland. See the upstream discussion here. Everyone seems to like it, so hopefully the protocol won't sit in wayland-protocols forever. I plan to merge this after the protocol gets upstreamed with a new release.
You can test this by using: swaywm/sway#6336