fix:send default and update consent payloads on kit init #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmustafa-tse
commented
Sep 10, 2024
src/common.js
Outdated
| // so we shouldn't send an update. | ||
| if (this.consentPayloadAsString && this.consentMappings) { | ||
|
|
||
| if (!this.isEmpty(consentState)) { |
There was a problem hiding this comment.
I can probably move this to the if statement at 150 to avoid unnecessary nested if statements
mmustafa-tse
commented
Sep 10, 2024
src/initialization.js
Outdated
| common.consentHandler.generateConsentStatePayloadFromMappings( | ||
| updatedConsentState, | ||
| common.consentMappings | ||
| ); |
There was a problem hiding this comment.
also this can become one var and then comma separated instead of having 3 vars for each, let me know if this is preferred
There was a problem hiding this comment.
moved it back to 3 vars instead of comma separated per meeting with @alexs-mparticle
mmustafa-tse
commented
Sep 10, 2024
src/initialization.js
Outdated
| updatedDefaultConsentPayload | ||
| ); | ||
|
|
||
| common.sendConsent('default', updatedDefaultConsentPayload); |
There was a problem hiding this comment.
I can probably make a function in common for lines 82-86 and 88-92 and call it here instead of having the same repeated lines of code since they're doing the same actions just with two different variables
alexs-mparticle
approved these changes
Sep 13, 2024
rmi22186
reviewed
Sep 18, 2024
alexs-mparticle
approved these changes
Sep 18, 2024
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)