Skip to content

Conversation

yan12125
Copy link
Contributor

@yan12125 yan12125 commented Jan 18, 2023

Closes #2564

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 99.52% // Head: 99.52% // No change to project coverage 👍

Coverage data is based on head (b46bcd6) compared to base (0bf4881).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2616   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          32       32           
  Lines        1699     1699           
=======================================
  Hits         1691     1691           
  Misses          8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yan12125 yan12125 changed the title [WIP] Support Node.js 19 Support Node.js 19 Jan 18, 2023
@yan12125 yan12125 marked this pull request as ready for review January 18, 2023 13:49
@Rob--W Rob--W mentioned this pull request Jan 19, 2023
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes lgtm. @rpl is going to look at Node 18 support (#2617), so I'm going to tag him as a reviewer before merging.

@Rob--W Rob--W requested a review from rpl January 19, 2023 14:24
@yan12125
Copy link
Contributor Author

Updated to resolve conflicts with #2618

@rpl rpl merged commit 54e7b79 into mozilla:master Feb 9, 2023
@yan12125 yan12125 deleted the nodejs19 branch February 14, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support develoment environment using Node.js 19
3 participants