chore: fix tests error message assertions to pass while running Node.js 19 (#2616)

Closes #2564

Author: yan12125

.circleci/config.yml

@@ -27,7 +27,8 @@ references:
   nodejs_versions:
     - &nodejs_current "14.19"
     - &nodejs_next "16.14"
-    - &nodejs_experimental "18.13"
+    # nodejs 19.3 comes with npm 9.0, which breaks "npm config set python" below
+    - &nodejs_experimental "19.2"
 
   nodejs_enum: &nodejs_enum
     type: enum

tests/unit/test-cmd/test.build.js

@@ -267,9 +267,14 @@ describe('build', () => {
         .then(makeSureItFails())
         .catch((error) => {
           assert.instanceOf(error, UsageError);
+          // Matching error messages from either Node.js < 19 or Node.js >= 19
+          // Node.js 19.0 includes V8 10.7 [1], and the latter includes changes to make JSON.parse errors user-friendly
+          // [1] https://github.com/nodejs/node/pull/44741
+          // [2] https://chromium-review.googlesource.com/c/v8/v8/+/3513684
+          // [3] https://chromium-review.googlesource.com/c/v8/v8/+/3652254
           assert.match(
             error.message,
-            /Unexpected string in JSON at position 14/
+            /Unexpected string in JSON at position 14|Expected ':' after property name in JSON at position 14/
           );
           assert.match(error.message, /^Error parsing messages\.json/);
           assert.include(error.message, messageFileName);

tests/unit/test-util/test.manifest.js

@@ -68,9 +68,11 @@ describe('util/manifest', () => {
                 error.message,
                 /Error parsing manifest\.json file at /
               );
-              assert.include(
+              // Matching error messages from either Node.js < 19 or Node.js >= 19
+              // See comments in tests/unit/test-cmd/test.build.js
+              assert.match(
                 error.message,
-                'Unexpected token "," (0x2C) in JSON at position 51'
+                /Unexpected token "," \(0x2C\) in JSON at position 51|Expected double-quoted property name in JSON at position 51/
               );
               assert.include(error.message, manifestFile);
             })