Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update dependency chrome-launcher to v0.13.3 and adapt chromium extension-runner and defaultFlags test case #1931

Merged
merged 2 commits into from
Jun 16, 2020
Merged

fix(deps): update dependency chrome-launcher to v0.13.3 and adapt chromium extension-runner and defaultFlags test case #1931

merged 2 commits into from
Jun 16, 2020

Conversation

rpl
Copy link
Member

@rpl rpl commented Jun 15, 2020

This pull request does supersede #1904.

Besides including the renovatebot changes from #1904 it is also:

  • fixing incompatibilities between the properties exported in chrome-launcher v.0.13.3 and what extension-runners/chromium.js is using internally
  • adding a new default flag included in v.0.13.3 into the test.chromium.js unit test

@rpl rpl requested a review from Rob--W June 15, 2020 18:24
@rpl rpl mentioned this pull request Jun 15, 2020
Closed
1 task
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a8c517f on rpl:update-deps/chrome-launcher-0.13.3 into 810f64c on mozilla:master.

@Rob--W Rob--W mentioned this pull request Jun 15, 2020
Merged
@rpl rpl merged commit 2741030 into mozilla:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob--W Rob--W Rob--W approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rpl @coveralls @Rob--W @renovate-bot