Skip to content

Commit

Permalink
fix(deps): update dependency chrome-launcher to v0.13.3 and adapt chr…
Browse files Browse the repository at this point in the history
…omium extension-runner and defaultFlags test case (#1931)

* fix(deps): update dependency chrome-launcher to v0.13.3

* chore: Fixes needed due to changes to exported properties in chrome-launcher v0.13.3

Co-authored-by: Renovate Bot <bot@renovateapp.com>
  • Loading branch information
rpl and renovate-bot authored Jun 16, 2020
1 parent 810f64c commit 2741030
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 11 deletions.
28 changes: 21 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"addons-linter": "1.23.0",
"bunyan": "1.8.12",
"camelcase": "5.3.1",
"chrome-launcher": "0.13.1",
"chrome-launcher": "0.13.3",
"debounce": "1.2.0",
"decamelize": "3.2.0",
"es6-error": "4.1.1",
Expand Down
5 changes: 2 additions & 3 deletions src/extension-runners/chromium.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@ import path from 'path';
import {fs} from 'mz';
import asyncMkdirp from 'mkdirp';
import {
LaunchedChrome,
Launcher as ChromeLauncher,
launch as defaultChromiumLaunch,
default as ChromeLauncher,
} from 'chrome-launcher';
import WebSocket from 'ws';

Expand Down Expand Up @@ -51,7 +50,7 @@ export const DEFAULT_CHROME_FLAGS = ChromeLauncher.defaultFlags()
export class ChromiumExtensionRunner {
cleanupCallbacks: Set<Function>;
params: ChromiumExtensionRunnerParams;
chromiumInstance: LaunchedChrome;
chromiumInstance: ChromeLauncher;
chromiumLaunch: typeof defaultChromiumLaunch;
reloadManagerExtension: string;
wss: WebSocket.Server;
Expand Down
1 change: 1 addition & 0 deletions tests/unit/test-extension-runners/test.chromium.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ describe('util/extension-runners/chromium', async () => {
'--disable-backgrounding-occluded-windows',
'--disable-renderer-backgrounding',
'--disable-background-timer-throttling',
'--force-fieldtrials=*BackgroundTracing/default/',
];

assert.deepEqual(DEFAULT_CHROME_FLAGS, expectedFlags);
Expand Down

0 comments on commit 2741030

Please sign in to comment.