Skip to content

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Mar 2, 2021

@mdboom mdboom requested a review from fbertsch March 3, 2021 18:09
@mdboom
Copy link
Contributor Author

mdboom commented Mar 3, 2021

I'm not sure I understand the failure:

       if any(
            schema.get_size() > max_size for _, s in schemas.items() for schema in s
        ):
            raise SchemaException(
>               "Schema must be smaller or equal max_size {}".format(max_size)
            )
E           mozilla_schema_generator.schema.SchemaException: Schema must be smaller or equal max_size 10000

mozilla_schema_generator/generic_ping.py:87: SchemaException

How could removing these things make the schema larger?

@jklukas
Copy link
Contributor

jklukas commented Mar 3, 2021

How could removing these things make the schema larger?

This is not your fault. It's a symptom of the volume of probes being scraped, so the scraper is currently failing prod as well. See https://bugzilla.mozilla.org/show_bug.cgi?id=1688633 for full context and mitigation plan.

Copy link
Contributor

@fbertsch fbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll merge this after https://bugzilla.mozilla.org/show_bug.cgi?id=1688633 is resolved

@fbertsch fbertsch closed this Mar 3, 2021
@fbertsch fbertsch reopened this Mar 3, 2021
@fbertsch
Copy link
Contributor

fbertsch commented Mar 8, 2021

Going to wait to deploy this until we get one schema deploy with #184.

@fbertsch fbertsch merged commit db7c439 into mozilla:main Mar 9, 2021
@fbertsch
Copy link
Contributor

fbertsch commented Mar 9, 2021

@mdboom We should see this deployed with the next schema deploy, EOD today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants