Bug 1695795: Remove unused metric types from the Glean schema #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Way back in the prehistory of Glean, we had a whole bunch of metric types planned that never saw the light of day. They may come back, not only through a formal design proposal process. Therefore, probably best to remove them to prevent their misuse and other confusion.
fbertsch
approved these changes
Mar 8, 2021
acmiyaguchi
pushed a commit
that referenced
this pull request
Mar 23, 2021
c2e18f4 2021-03-23 18:04:10 +0000 Bug 1697602 Remove AET schemas (#664) 5f21300 2021-03-17 19:04:16 +0000 Bug 1677567 - Add rallyId to pioneer metadata schemas (#665) 731721a 2021-03-09 10:03:38 -0800 Bug 1696074 - Add schema for uninstall-deletion ping in pioneer-core (#663) 793fc04 2021-03-08 09:55:50 -0500 Bug 1695795: Remove unused metric types from the Glean schema (#662) 04043f1 2021-03-02 08:30:04 -0500 Fix #660: Add the rate metric type (#661) 0a24af0 2021-02-24 10:43:58 -0500 [Bug 1694254] Add environment.settings.attribution.dltoken field c2dae92 2021-02-22 18:30:19 +0000 Bug 1693305 - Clone citp-news-disinfo study (#658) f3a1464 2021-02-17 16:05:26 -0600 Bug 1688698 - Add 'source' to TopSites schemas in Contextual Services (#657) 5904f8c 2021-02-12 16:29:41 -0600 Bug 1688698 - Add initial schemas for Contextual Services (#656)
bytesized
pushed a commit
to bytesized/mozilla-pipeline-schemas
that referenced
this pull request
Aug 23, 2022
…a-services#662) * Bug 1695795: Remove unused metric types from the Glean schema Way back in the prehistory of Glean, we had a whole bunch of metric types planned that never saw the light of day. They may come back, not only through a formal design proposal process. Therefore, probably best to remove them to prevent their misuse and other confusion. * Add CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way back in the prehistory of Glean, we had a whole bunch of metric types
planned that never saw the light of day. They may come back, but only through a
formal design proposal process. Therefore, probably best to remove them to
prevent their misuse and other confusion.
Checklist for reviewer:
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsintegrationCI test by pushing this revision as discussed in the README and review the report posted in the comments.For glean changes:
templates/include/glean/CHANGELOG.md